Deprecate gossip blobs#9126
Open
eserilev wants to merge 26 commits intosigp:unstablefrom
Open
Conversation
Member
|
Fulu happened on Gnosis yesterday, so we are good to go! |
jimmygchen
added
waiting-on-author
eserilev
added
ready-for-review
|
Some required checks have failed. Could you please take a look @eserilev? 🙏 |
mergify
Bot
added
waiting-on-author
dapplion
reviewed
Apr 22, 2026
| /// Cache the blobs in the processing cache, process it, then evict it from the cache if it was | ||
| /// imported or errors. | ||
| #[instrument(skip_all, level = "debug")] | ||
| pub async fn process_rpc_blobs( |
Collaborator
There was a problem hiding this comment.
Should this function be deleted too?
| .contains_block(&parent_root) | ||
| { | ||
| return Err(BlockError::ParentUnknown { parent_root }); | ||
| for blob in &blobs { |
Collaborator
There was a problem hiding this comment.
What's the reason of this change anyway?
| .expect("should import valid gossip verified blob"); | ||
| } | ||
| DataSidecars::Blobs(_blob_sidecars) => { | ||
| // Blob gossip is deprecated, blobs are available via RPC. |
Collaborator
There was a problem hiding this comment.
Should this be an error instead? Or remove DataSidecars::Blobs
…precate-gossip-blobs
The PR removes the pre-Fulu publish path in publish_blocks.rs, so any block with blobs must use Fulu cell proofs. - get_blob_sidecars test: was Deneb-only and called test_post_beacon_blocks_valid; switched to Fulu + Supernode so the publish path's data-column construction succeeds and blob sidecars are reconstructed from columns - basic_sim / fallback_sim: blob-relevant forks all at genesis (Fulu from slot 0) and Gloas at epoch 2 as the fork-transition target, avoiding the multi-fork-at- same-epoch state.fork.previous_version mismatch that broke sync aggregate verification across the boundary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#9124
Deprecate unneeded pre-Fulu blob features
Also deprecates some tests and cleans up production code paths
I think this is blocked until gnosis forks to fulu?