merge queue: embarking unstable (c028bac) and #8998 together#9149
Closed
mergify[bot] wants to merge 133 commits intounstablefrom
Closed
merge queue: embarking unstable (c028bac) and #8998 together#9149mergify[bot] wants to merge 133 commits intounstablefrom
mergify[bot] wants to merge 133 commits intounstablefrom
Conversation
Gloas genesis calls initialize_ptc_window which requires non-empty committee indices per slot. With MainnetEthSpec (32 slots/epoch), tests with < 32 validators leave some slots with zero committee members, causing InvalidIndicesCount errors. Bump validator counts to >= 32.
- Bump block_verification VALIDATOR_COUNT to 32 for Gloas genesis
- Fix attestation_to_finalized_block: use get_cold_state_root to resolve
pending vs full state root mismatch in cold DB lookups
- Skip chain_dump-based block_verification tests for Gloas (chain_dump
envelope/fullness logic is WIP, depends on fork choice changes)
- Add Gloas doc comment to HotColdDB::get_state
- Expand TODO in sync_committee_rewards for pending root issue
Gloas moves blobs into the execution payload envelope, so blob_kzg_commitments is not present on the block body. Tests that iterate blocks looking for blob commitments or produce blocks with blobs need to be skipped for Gloas. Also bump column_verification VALIDATOR_COUNT to 32 for Gloas genesis compatibility.
- Skip blob/column tests for Gloas (blobs in execution payload envelope) - Skip light client tests for Gloas (not yet implemented) - Skip chain_dump/iterators in schema_downgrade for Gloas (BlockReplayer bug) - Skip missed_blocks_across_epochs for Gloas (BlockReplayer state root bug) - Bump missed_blocks_basic validator count 16->32 for Gloas genesis - Add Gloas arm in massive_skips expecting InvalidIndicesCount - Bump column_verification VALIDATOR_COUNT 24->32 for Gloas genesis
…x-pruning-gloas
2 tasks
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch unstable (c028bac) and #8998 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #8998.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:#approved-reviews-by >= 1[🛡 GitHub branch protection]#changes-requested-reviews-by = 0[🛡 GitHub branch protection]check-success=local-testnet-successcheck-success=test-suite-successRequired conditions to stay in the queue:
#approved-reviews-by >= 1#approved-reviews-by >= 1[🛡 GitHub branch protection]#changes-requested-reviews-by = 0[🛡 GitHub branch protection]check-success=license/clacheck-success=target-branch-checklabel!=do-not-merge