Update proposer boost calculation#9215
Merged
mergify[bot] merged 2 commits intosigp:unstablefrom Apr 29, 2026
Merged
Conversation
|
Some required checks have failed. Could you please take a look @michaelsproul? 🙏 |
Member
Author
|
Working on the test failure now |
Merge Queue Status
This pull request spent 28 minutes 46 seconds in the queue, including 27 minutes 23 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes:
update_proposer_boost_rootin fork choice #8689Proposed Changes
slotand plumb it through to fork choice so it can be used to determine whether or not to apply the proposer boost. We use the proposer cache to handle state advances and avoid duplicate work.block.message().proposer_index()(always pass), we are not attempting to test this feature in those tests. The EF tests use the correct canonical proposer idnex viaon_block, except for invalid blocks which just auto-pass this check (these blocks get rejected by other checks inon_blockanyway).Additional Info
This change may help us pass more of the fork choice compliance tests: