Skip to content

Update proposer boost calculation#9215

Merged
mergify[bot] merged 2 commits intosigp:unstablefrom
michaelsproul:fc-update-proposer-boost
Apr 29, 2026
Merged

Update proposer boost calculation#9215
mergify[bot] merged 2 commits intosigp:unstablefrom
michaelsproul:fc-update-proposer-boost

Conversation

@michaelsproul
Copy link
Copy Markdown
Member

Issue Addressed

Closes:

Proposed Changes

  • Calculate the proposer index on the canonical chain (from canonical head) at slot and plumb it through to fork choice so it can be used to determine whether or not to apply the proposer boost. We use the proposer cache to handle state advances and avoid duplicate work.
  • Update our FC tests to use block.message().proposer_index() (always pass), we are not attempting to test this feature in those tests. The EF tests use the correct canonical proposer idnex via on_block, except for invalid blocks which just auto-pass this check (these blocks get rejected by other checks in on_block anyway).

Additional Info

This change may help us pass more of the fork choice compliance tests:

@michaelsproul michaelsproul added ready-for-review The code is ready for review fork-choice labels Apr 29, 2026
@mergify
Copy link
Copy Markdown

mergify Bot commented Apr 29, 2026

Some required checks have failed. Could you please take a look @michaelsproul? 🙏

@mergify mergify Bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Apr 29, 2026
@michaelsproul
Copy link
Copy Markdown
Member Author

Working on the test failure now

@mergify mergify Bot added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Apr 29, 2026
Copy link
Copy Markdown
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Apr 29, 2026
@mergify mergify Bot added the queued label Apr 29, 2026
@mergify
Copy link
Copy Markdown

mergify Bot commented Apr 29, 2026

Merge Queue Status

This pull request spent 28 minutes 46 seconds in the queue, including 27 minutes 23 seconds running CI.

Required conditions to merge

mergify Bot added a commit that referenced this pull request Apr 29, 2026
@mergify mergify Bot merged commit f406e9c into sigp:unstable Apr 29, 2026
38 of 39 checks passed
@mergify mergify Bot removed the queued label Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork-choice ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants