Optimise hdiff buffer handling by (re)using Milhouse data structures#9236
Open
michaelsproul wants to merge 14 commits intosigp:unstablefrom
Open
Optimise hdiff buffer handling by (re)using Milhouse data structures#9236michaelsproul wants to merge 14 commits intosigp:unstablefrom
michaelsproul wants to merge 14 commits intosigp:unstablefrom
Conversation
- `CompressedU64Diff::apply`: Use a dense/sparse hybrid strategy. When >50% of elements change, rebuild the List from scratch. Otherwise, use copy-on-write `get_mut` for only non-zero diffs. This significantly speeds up inactivity scores (all-zero diffs). - `ValidatorsDiff::apply`: Collect updates into a BTreeMap and use `bulk_update` instead of per-element `get_mut`, avoiding repeated copy-on-write tree modifications. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Temporary eprintln! timing for each diff component to stderr for profiling purposes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
michaelsproul
added
work-in-progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Core idea is using Milhouse types in
HDiffBufferso we can avoid cloning in and out of vecs, and preserve structural sharing across diff application.Benchmarks to come (from
lcli apply-hdiff/compute-hdiffnewly added)