fix: restore genesis_block bid population for ef-tests#9246
Merged
jking-aus merged 2 commits intosigp:glamsterdam-devnet-2from Apr 30, 2026
Merged
fix: restore genesis_block bid population for ef-tests#9246jking-aus merged 2 commits intosigp:glamsterdam-devnet-2from
jking-aus merged 2 commits intosigp:glamsterdam-devnet-2from
Conversation
The alpha-7 spec tests expect the Gloas genesis block body to contain the execution payload bid from state. Restores the genesis_block() function and body_root fixup that were removed in PR sigp#9244. The fork choice from_anchor fix (reading latest_block_hash when bid hashes are zero) remains for Kurtosis/external genesis compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
genesis_block()to populate the Gloas block body withstate.latest_execution_payload_bid(required by alpha-7 spec test vectors)body_rootfixup ininitialize_beacon_state_from_eth1()so state and block roots stay consistentfrom_anchorfix (readinglatest_block_hashwhen bid hashes are zero) remains intact for Kurtosis/external genesis compatibilityContext
PR #9244 simplified
genesis_block()to return an empty block for Kurtosis interop, but the alpha-7 ef-tests expect the bid in the genesis block body. Both paths are needed:latest_block_hashfrom state when bid is all-zerosTest plan
ef-tests-ubuntuCI job passes (fork_choice_get_head, fork_choice_ex_ante, etc.)