Conversation
eshattow
marked this pull request as ready for review
May 6, 2026 13:04
Contributor
Author
|
This PR does work as intended but it is more noisy on GitHub Actions logging output than desired, and I would like some advice what are the threat models we're addressing? Why not just checkout cosign_checksums.txt asset at runtime, and query GitHub Actions API directly the sha256 sum of sigstore/cosign cosign_checksums.txt to include with cosign-installer release ? In any event, I hope the jq strategy is interesting and useful. |
…setup Streamline the cosign version bump process by importing cosign_checksum.txt as a heredoc, validate inputs with jq regex, and output variables. Side-effect is this allows support for all OS and ARCHITECTURE releases published by upstream cosign. Adds a configuration JSON formatted snippet for env overrides on valid release filenames, by OS and ARCHITECTURE. If either OS or ARCHITECTURE are not matched in the configuration then assume to use ascii_downcase processed runner OS and runner ARCHITECTURE names to match within cosign_checksums.txt data. Signed-off-by: E Shattow <eshattow@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streamline the cosign version bump process by importing cosign_checksum.txt as a heredoc, validate inputs with jq regex, and output variables.
Side-effect is this allows support for all OS and ARCHITECTURE releases published by upstream cosign. Adds a configuration JSON formatted snippet for env overrides on valid release filenames, by OS and ARCHITECTURE. If either OS or ARCHITECTURE are not matched in the configuration then assume to use ascii_downcase processed runner OS and runner ARCHITECTURE names to match within cosign_checksums.txt data.
Resolves: #228
Resolves: #233