FEAT#Allow Enable/Disable Kubernetes Service Links

[nkreiger]

Description of the change

This Change/Proposal, is to allow setting the enableServiceLinks boolean in a kubernetes deployment via the helm charts. This is kind of an obscure configuration ask.

This variable (true by default), will automatically map all the service names and hosts into the environment variables of a kubernetes deployment. However, there is a limit to this, and when that limit is hit, you get the error too many args, whenever a pod restarts or during a new deployment.

Honestly, not sure why the default is true, it should only effect you if you are not using the DNS name when interacting with other services, which is not the case here.

Existing or Associated Issue(s)

Additional Information

Checklist

• Chart version bumped in Chart.yaml according to semver. Where applicable, update and bump the versions in any associated umbrella chart
• Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
• JSON Schema generated.
• List tests pass for Chart using the Chart Testing tool and the ct lint command.

[nkreiger]

I wasn't sure if I should just keep this forked, or open a PR, if this is something to move forward with, I can do the checklist, let me know.

[sabre1041]

A few items that need to be added before we can look to integrate this feature:

• Instead of a dictionary called serviceLinks, what about a boolean called serviceLinksEnabled and use that conditional and value in the deployment?
• Chart.yaml version bump
• JSON Schema values update
• Chart dependencies need to be updated between the charts

Given that this change is spread across multiple charts, separating them out across multiple PR's would be a better approach given the fact that chart testing needs to be able to resolve them effectively

[nkreiger]

hey @sabre1041 yep, mostly considered this a request, more of the "final" pr. I will spread these out, and use the same strategy here with the dictionary boolean