Return cached cert first when signing#1838
Merged
Merged
Conversation
Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
woodruffw
reviewed
Jul 25, 2026
Comment on lines
+76
to
+85
| def test_signer_uses_valid_cached_certificate_with_expired_identity(): | ||
| cert = pretend.stub( | ||
| not_valid_after_utc=datetime.now(timezone.utc) + timedelta(minutes=5) | ||
| ) | ||
|
|
||
| signer = Signer.__new__(Signer) | ||
| signer._identity_token = pretend.stub(in_validity_period=lambda: False) | ||
| signer._Signer__cached_signing_certificate = cert | ||
|
|
||
| assert signer._signing_cert() is cert |
Member
There was a problem hiding this comment.
Minor: any way we can do this with less stubbing? It'd be nice to exercise a real cached flow here.
Collaborator
Author
There was a problem hiding this comment.
done, see the new test
woodruffw
previously approved these changes
Jul 25, 2026
woodruffw
left a comment
woodruffw
left a comment
Member
There was a problem hiding this comment.
Thanks @facutuesca!
This seems reasonable to me, only one nitpick about the test.
Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
woodruffw
approved these changes
Jul 26, 2026
Member
|
Thank you @facutuesca! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the discussion in #1729 (comment)
When signing, use the (valid) cached cert even if the identity token is already expired.
Should fix pypa/gh-action-pypi-publish#415 once we make a release and update
pypi-attestationswith it.