Skip to content

SF-3770 Separate books in the Serval Admin CSV with semicolons#3782

Merged
marksvc merged 2 commits intomasterfrom
fix/SF-3770
Apr 10, 2026
Merged

SF-3770 Separate books in the Serval Admin CSV with semicolons#3782
marksvc merged 2 commits intomasterfrom
fix/SF-3770

Conversation

@pmachapman
Copy link
Copy Markdown
Collaborator

@pmachapman pmachapman commented Apr 7, 2026


Open with Devin

This change is Reviewable

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 0 potential issues.

View 1 additional finding in Devin Review.

Open in Devin Review

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.30%. Comparing base (25e689b) to head (17344a2).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3782   +/-   ##
=======================================
  Coverage   81.30%   81.30%           
=======================================
  Files         622      622           
  Lines       39387    39387           
  Branches     6414     6390   -24     
=======================================
  Hits        32025    32025           
  Misses       6377     6377           
  Partials      985      985           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marksvc
Copy link
Copy Markdown
Collaborator

marksvc commented Apr 8, 2026

Ah, one of the motivations for formats like Rows of String Values (RSV) :-)
I've also recently become aware of JSONL, but haven't looked at it enough to know if I prefer it over RSV.

(Not to imply that everyone can open a RSV or JSONL file as easily as a CSV file in 2026.)

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 0 new potential issues.

View 2 additional findings in Devin Review.

Open in Devin Review

@Nateowami
Copy link
Copy Markdown
Collaborator

@marksvc This doesn't actually have anything to do with CSV using commas. It's so it's so a list of books and chapters can easily be parsed (e.g. GEN 3,4; RUT), by not using the same separator for both books and chapters.

@marksvc marksvc self-assigned this Apr 10, 2026
Copy link
Copy Markdown
Collaborator

@marksvc marksvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nateowami I was wrong.

BTW I learned today that LibreOffice now can import JSON into a spreadsheet! But not necessarily write it back. And no indication of importing JSONL at present.

@marksvc reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@marksvc marksvc enabled auto-merge (squash) April 10, 2026 22:04
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 0 new potential issues.

View 3 additional findings in Devin Review.

Open in Devin Review

@marksvc marksvc merged commit e17367b into master Apr 10, 2026
22 checks passed
@marksvc marksvc deleted the fix/SF-3770 branch April 10, 2026 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants