Update main 270426#20
Conversation
* Fixes to lerobot finetuning workload * pin lerobot default version and extra packages
There was a problem hiding this comment.
Pull request overview
Updates the robotics-finetune-lerobot Helm workload configuration to better control LeRobot installation/runtime behavior (pinning LeRobot source, adjusting training defaults, and tightening a few chart/runtime details).
Changes:
- Pin LeRobot install behavior via default extras and an optional git ref, plus improve package installation commands in the entrypoint.
- Adjust default training hyperparameters and metadata label defaults in
values.yaml/ overrides. - Fix
emptyDir.sizeLimitYAML structure and add a brief compatibility note to the README.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| workloads/robotics-finetune-lerobot/helm/values.yaml | Sets default LeRobot extras + git ref and updates training/metadata defaults. |
| workloads/robotics-finetune-lerobot/helm/templates/_helpers.tpl | Corrects emptyDir volume sizeLimit placement under emptyDir:. |
| workloads/robotics-finetune-lerobot/helm/overrides/pi05-kettle.yaml | Expands LeRobot extras used by the pi05-kettle override. |
| workloads/robotics-finetune-lerobot/helm/mount/entrypoint.sh.tpl | Improves apt usage, uses shallow clone, adds optional checkout, and requires hfFinetunedModelId. |
| workloads/robotics-finetune-lerobot/helm/README.md | Adds compatibility note and fixes a small grammar issue. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| git clone --depth 1 https://github.com/huggingface/lerobot.git | ||
| cd lerobot | ||
| {{- if .Values.setup.lerobotGitRef }} | ||
| git checkout {{ .Values.setup.lerobotGitRef }} | ||
| {{- end }} |
There was a problem hiding this comment.
git clone --depth 1 will usually prevent git checkout {{ .Values.setup.lerobotGitRef }} from working when lerobotGitRef is a specific commit SHA (not the repo’s current HEAD), causing the entrypoint to fail by default (since values.yaml now sets a SHA). Consider either (a) not using a shallow clone when lerobotGitRef is set, or (b) fetching that ref explicitly (e.g., git fetch --depth 1 origin <ref>) before checkout.
| git clone --depth 1 https://github.com/huggingface/lerobot.git | ||
| cd lerobot | ||
| {{- if .Values.setup.lerobotGitRef }} | ||
| git checkout {{ .Values.setup.lerobotGitRef }} |
There was a problem hiding this comment.
{{ .Values.setup.lerobotGitRef }} is interpolated into a shell command unquoted. If the value contains whitespace or shell metacharacters it can break the script (and can be used for command injection if values are not fully trusted). Quote the ref and pass it as a single argument (e.g., git checkout -- "<ref>").
| git checkout {{ .Values.setup.lerobotGitRef }} | |
| git checkout -- {{ .Values.setup.lerobotGitRef | quote }} |
|
Superseded by newer update |
No description provided.