fix: prevent I/O errors during disk cleanup by ensuring devices are unmounted#234
Merged
Conversation
…nmounted Critical bug fix for EAI-5787: The cleanup process was causing nodes to become unresponsive with I/O errors due to attempting wipefs/mkfs on mounted or in-use devices. Changes: - Add final forced unmount pass for all CLUSTER_DISKS before wiping - Add 10-second delay to allow kernel to fully release devices - Verify each device is unmounted with findmnt before wipefs/mkfs - Skip devices that are still mounted to prevent system corruption This prevents the catastrophic I/O errors that were making GPU worker nodes unresponsive when running bloom cleanup on systems with multiple NVMe devices.
Q-Dub
requested review from
a team,
brownzebra,
mramdgh,
oskarasbrink and
silokimmo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EAI-5787_bloom_cleanup
Critical bug fix for EAI-5787: The cleanup process was causing nodes to become unresponsive with I/O errors due to attempting wipefs/mkfs on mounted or in-use devices.
Changes:
This prevents the catastrophic I/O errors that were making GPU worker nodes unresponsive when running bloom cleanup on systems with multiple NVMe devices.