Open
Conversation
Replace ownerReference-based ownership of ClusterQueues with a kaiwo.silogen.ai/managed-by label. The ownerReference caused Kubernetes GC to cascade-delete all ClusterQueues when KaiwoQueueConfig was deleted, but Kueue's resource-in-use finalizer blocked deletion of queues with active workloads, creating a permanent deadlock where terminating queues blocked creation of replacements with the same name. Changes: - Replace SetControllerReference with managed-by label on ClusterQueues - Filter ClusterQueue list to only Kaiwo-managed queues - Skip terminating ClusterQueues instead of trying to update them - Add RequeueAfter on sync failure so the reconciler retries - Watch ClusterQueues so deletions trigger re-reconciliation - Migrate existing ClusterQueues by adding label and stripping stale ownerReferences on first reconciliation - Fix double r.Delete() call in the cleanup loop
Verifies that ClusterQueues created by the operator have the managed-by label, no ownerReferences, and survive KaiwoQueueConfig deletion without being cascade-deleted.
salexo
force-pushed
the
fix/clusterqueue-cascade-deletion
branch
from
eac9cad to
733586d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recreating the KaiwoQueueConfig while there are active workloads attached to Kueue ClusterQueues caused a deadlock. This PR provides a fix by removing owner references between KaiwoQueueConfig and ClusterQueues.