Skip to content

feat(comments): file attachments on mobile comments - #462

Draft
nossila wants to merge 3 commits into
masterfrom
feature/native-comment-attachments
Draft

nossila wants to merge 3 commits into
masterfrom
feature/native-comment-attachments

Merge branch 'master' into feature/native-comment-attachments

cb2d9ec
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Oct 15, 2026 in 34s

Annotations

Check warning on line 53 in packages/components/modules/files/common/utils/formatters.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read.

See more on https://sonarcloud.io/project/issues?id=silverlogic_baseapp-frontend&issues=AaEegOwyl9jCT5nsCxZp&open=AaEegOwyl9jCT5nsCxZp&pullRequest=462

Check warning on line 55 in packages/components/modules/files/native/utils/createNativeUploadSource.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Async method 'readChunk' has no 'await' expression.

See more on https://sonarcloud.io/project/issues?id=silverlogic_baseapp-frontend&issues=AaEegO1ol9jCT5nsCxZs&open=AaEegO1ol9jCT5nsCxZs&pullRequest=462

Check warning on line 5 in packages/components/modules/files/common/utils/uploadItemState.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

`REMOVABLE_STATUSES` should be a `Set`, and use `REMOVABLE_STATUSES.has()` to check existence or non-existence.

See more on https://sonarcloud.io/project/issues?id=silverlogic_baseapp-frontend&issues=AaEegO0Vl9jCT5nsCxZq&open=AaEegO0Vl9jCT5nsCxZq&pullRequest=462

Check warning on line 18 in packages/components/modules/files/common/utils/uploadSource.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Async method 'readChunk' has no 'await' expression.

See more on https://sonarcloud.io/project/issues?id=silverlogic_baseapp-frontend&issues=AaEegO0dl9jCT5nsCxZr&open=AaEegO0dl9jCT5nsCxZr&pullRequest=462