fix(tauri): stop Windows recall panel from resizing window and leaving a phantom column#351
Merged
Conversation
…g a phantom column
On Windows the embedded AI-assistant (Recall) panel produced two layout
problems that don't occur on macOS:
1. Opening/closing the panel resized the OS window (expand→960, collapse→520)
via cmd_apply_recall_window_layout. On macOS this "grow to fit, snap back"
is intentional, but on Windows it snapped the window to a fixed 520px on
close regardless of the user's size, and the timing left transient
whitespace. Skip the OS resize on Windows (IS_WINDOWS guard in
applyRecallWindowLayout) — the CSS flex layout reflows on its own, so the
window stays at whatever size the user set.
2. The top-level `.recall-panel { padding: 16px }` rule, combined with
`width: 0` and `box-sizing: border-box`, forced the collapsed panel to
render ~32px wide — a permanent empty column on the right of the home view.
macOS never showed it because the window shrinks below the panel's footprint
on collapse. Zero the padding for the collapsed panel on non-macOS only.
Both changes are platform-gated; macOS behavior is unchanged.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
@maosuarez is attempting to deploy a commit to the evil genius laboratory Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
Merged, thank you. This is exactly the kind of Windows coverage the project needs most, and the platform gating is clean. I especially appreciate the comments explaining why the macOS resize is intentional and why the collapsed padding only matters off-mac. That context makes this easy to maintain later. Hope to see more from you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows, the embedded AI-assistant (Recall) panel caused two layout issues on the home view that don't occur on macOS (I am a win user):
Window resizes when toggling the panel. Opening/closing the panel drives an OS-level window resize (expand → 960px, collapse → 520px) through
cmd_apply_recall_window_layout. On macOS this "grow to fit, snap back" is intentional, but on Windows it snaps the window to a fixed 520px on close regardless of the size the user chose, and the timing leaves transient whitespace.Phantom empty column when the panel is collapsed. The top-level
.recall-panel { padding: 16px }rule, combined withwidth: 0and the globalbox-sizing: border-box, forces the collapsed panel to render ~32px wide — a permanent empty column on the right edge of the home view. macOS never shows it because the window shrinks below the panel's footprint on collapse.Fix
Both changes are platform-gated; macOS behavior is byte-for-byte unchanged.
Skip the OS window resize on Windows (
IS_WINDOWSguard, early-return inapplyRecallWindowLayout). The CSS flex layout (.recall-panelwidth: 0↔expanded,.app-left { flex: 1 }) reflows on its own, so the window stays at whatever size the user set.Zero the padding on the collapsed panel for non-macOS only:
The expanded panel keeps its 16px padding (the terminal needs it).
Linux also benefits from fix #2 (it had the same phantom column); the rule is gated away from macOS, not toward a single platform, and removes a gap that shouldn't exist anywhere.
Scope
tauri/src/index.html(+21 lines)Testing
Verified visually on Windows 11 with
cargo tauri dev: