Add window size commands and tab navigation hotkeys by simeji · Pull Request #44 · simeji/winresizer

simeji · 2026-03-28T14:46:35Z

Summary

Implements a subset of the features proposed in #30, adapted to match the existing codebase conventions:

_ (hfull, ASCII 95) — maximize current window height (wincmd _) — resize mode only
| (vfull, ASCII 124) — maximize current window width (wincmd |) — resize mode only
= (sizeeq, ASCII 61) — equalize all window sizes (wincmd =) — resize mode only
J (tabl, ASCII 74) — switch to previous tab — all modes
K (tabr, ASCII 75) — switch to next tab — all modes

All new keycodes are configurable via g:winresizer_keycode_* variables and documented in README.md.

Changes from #30

Close key excluded (already shipped in [Feature Request] Window close hotkey #29 as x)
sleep 1 pattern not used — dispatch executes commands directly, consistent with all other hotkeys
No new autoload functions needed; vim built-in commands used directly

Test plan

All 36 vader tests pass (vim -Es -u test/vimrc '+Vader! test/winresizer.vader')
10 new test cases covering keycode defaults and hotkey behaviour for all 5 new commands
CI will run on push

Implement hfull (_), vfull (|), sizeeq (=) for window size control in resize mode, and tabl (J) / tabr (K) for tab navigation across all modes. All new keycodes are configurable via g:winresizer_keycode_* variables. Closes #30 (partial: excludes close key already implemented in #29)

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eb744dc2c9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-28T14:50:06Z

+    elseif c == s:codeList['tabl'] && has_key(l:commands, 'tabl') "J
+      exe l:commands['tabl']
+    elseif c == s:codeList['tabr'] && has_key(l:commands, 'tabr') "K
+      exe l:commands['tabr']


Refresh mode commands after tab navigation

In s:startResize, the new tabl/tabr handlers execute tabprevious/tabnext but leave l:commands unchanged, so the loop continues using command state captured on the previous tab. In resize mode this state includes edge-dependent left/right/up/down behavior and a winrestcmd() cancel snapshot, which can become incorrect immediately after J/K when tabs have different window layouts (for example, h can resize in the opposite direction and q can restore the wrong geometry). Rebuild l:commands for the current mode after each tab switch to keep behavior consistent.

Useful? React with 👍 / 👎.

After J/K switches tabs, edge detection and winrestcmd() snapshots in l:commands reflect the previous tab's layout. Introduce s:commandsForMode() and call it after each tab switch so resize direction and cancel behavior are always consistent with the current tab.

simeji · 2026-03-28T15:01:44Z

Addressed in 9b0fa03 (re: Codex review): introduced s:commandsForMode() and call it after each J/K tab switch, so both the edge-dependent resize directions and the winrestcmd() cancel snapshot are rebuilt against the new tab's layout. Added a test case to cover the cancel behavior after tab navigation.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9b0fa03a01

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-28T15:04:45Z

+  else
+    return s:tuiResizeCommands()


Preserve GUI resize mode when rebuilding commands

When WinResizerStartResizeGUI is active, pressing J/K triggers command refresh via s:commandsForMode(l:commands['mode']), but this helper maps 'resize' to s:tuiResizeCommands() unconditionally. That means a GUI session silently flips to the TUI command set after the first tab navigation, so subsequent h/j/k/l and q operate on split/window layout state instead of GUI &columns/&lines, which is a functional regression for GUI users.

Useful? React with 👍 / 👎.

Rename guiResizeCommands mode from 'resize' to 'gui_resize' so that s:commandsForMode() can distinguish TUI and GUI resize sessions and return the correct command set after J/K tab navigation.

simeji · 2026-03-28T15:17:01Z

Addressed in 36c5140 (re: Codex review): renamed the GUI resize mode identifier from 'resize' to 'gui_resize' and added a branch in s:commandsForMode() to return s:guiResizeCommands() for that case. TUI and GUI resize sessions are now distinguished correctly after tab navigation.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 36c5140217

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-28T15:20:54Z

+      exe l:commands['sizeeq']
+    elseif c == s:codeList['tabl'] && has_key(l:commands, 'tabl') "J
+      exe l:commands['tabl']
+      let l:commands = s:commandsForMode(l:commands['mode'])


Preserve GUI cancel snapshot after tab navigation

Rebuilding l:commands immediately after J/K recreates gui_resize commands, including a new cancel value based on the current &columns/&lines. In GUI resize mode this means q stops undoing earlier frame-size changes once a tab switch occurs (e.g., resize with h/l, press J, then q leaves the resized dimensions in place). Keep the original GUI cancel snapshot when handling tab navigation so cancel still restores the pre-session size.

Useful? React with 👍 / 👎.

simeji · 2026-03-28T15:33:20Z

Re: Codex review on GUI cancel snapshot: skipping this one intentionally.

For TUI mode, rebuilding l:commands after tab switch is correct — the old winrestcmd() snapshot references window numbers from the previous tab and would be meaningless (or harmful) on the new tab. For GUI mode, preserving the original cancel across tab switches would be more accurate, but the behaviour depends on user expectation ("undo all session changes" vs. "undo since last tab switch"), and GUI resize + in-session tab navigation is a sufficiently niche combination that we're treating this as a known limitation rather than a blocking fix.

chatgpt-codex-connector Bot reviewed Mar 28, 2026

View reviewed changes

Fix s:commandsForMode to preserve GUI resize mode after tab switch

36c5140

Rename guiResizeCommands mode from 'resize' to 'gui_resize' so that s:commandsForMode() can distinguish TUI and GUI resize sessions and return the correct command set after J/K tab navigation.

chatgpt-codex-connector Bot reviewed Mar 28, 2026

View reviewed changes

Update doc/winresizer.txt with new keycodes and focus mode keys

c3e5bbd

simeji merged commit 299076f into master Mar 28, 2026
2 checks passed

simeji deleted the feature/size-and-tab-commands branch March 28, 2026 15:38

simeji mentioned this pull request Mar 28, 2026

Add some commands #30

Closed

Navigation Menu

Add window size commands and tab navigation hotkeys - #44

Add window size commands and tab navigation hotkeys#44
simeji merged 4 commits into
masterfrom
feature/size-and-tab-commands

simeji commented Mar 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Mar 28, 2026

Uh oh!

simeji commented Mar 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Mar 28, 2026

Uh oh!

simeji commented Mar 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Mar 28, 2026

Uh oh!

simeji commented Mar 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

simeji commented Mar 28, 2026

Summary

Changes from #30

Test plan

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

simeji commented Mar 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

simeji commented Mar 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

simeji commented Mar 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant