Allow consuming the output of bean-report #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmarciniak
force-pushed
the
bug-fixes
branch
2 times, most recently
from
015a425 to
6e75993
Compare
pmarciniak
force-pushed
the
bug-fixes
branch
2 times, most recently
from
2fbe7f1 to
0664581
Compare
This is useful when passing a concatenation of multiple Beancount files as an input to bean-add (as suggested in simon-v#3 (comment)). However, in order for the statements to be sorted by date (a prerequisite for bean-add to work correctly), it's better to use "bean-report print main.bnct > merged.bnct" rather than "cat *.bnct > merged.bnct". bean-report uses comma separator when printing large numbers (e.g., 12,344.50 CHF). This commit makes bean-add able to parse such numbers.
This is useful when passing a concatenation of multiple Beancount files as an input to bean-add (as suggested in simon-v#3 (comment)). However, in order for the statements to be sorted by date (a prerequisite for bean-add to work correctly), it's better to use "bean-report print main.bnct > merged.bnct" rather than "cat *.bnct > merged.bnct". For every pad statement, bean-report inserts a padding transaction flagged with 'P', e.g.: 2019-03-09 P "(Padding inserted for Balance of 124.10 CHF for difference 15.20 CHF)" This commit makes bean-add able to parse such transactions.
…s when parsing amounts.
…xception when encountering unknown option.
…eError exception when encountering unknown option." This fix has been PR'd independently in simon-v#15 This reverts commit 0119972.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful when passing a concatenation of multiple Beancount files as an input to bean-add (as suggested in #3 (comment)). However, in order for the statements to be sorted by date (a prerequisite for bean-add to work correctly), it's better to use "bean-report print main.bnct > merged.bnct" rather than "cat *.bnct > merged.bnct".
The output of bean-report has some features that bean-add couldn't handle:
2019-03-09 P "(Padding inserted for Balance of 124.10 CHF for difference 15.20 CHF)"bean-add would crash on encountering such transactions.
This PR resolves the above 2 problems.