Fix supports_schema attribute name in advanced model plugins docs - #1686
Merged
Merged
Conversation
The example set support_schema = True, but the attribute llm reads (and the prose above the example) is supports_schema. Closes simonw#814
anandfresh
approved these changes
Sep 18, 2026
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #814
The schema example in
docs/plugins/advanced-model-plugins.mdsetssupport_schema = True, but the attribute llm checks (supports_schemainllm/models.py, and the sentence just above the example) has ans. A plugin author copying the snippet would silently get no schema support.AI disclosure: this change was made with Claude Code; I checked the attribute name against
llm/models.py.