Assert the $_db_notify database-rebuild gating - #171
Open
hcaballero2 wants to merge 2 commits into
Open
Conversation
spec/classes/init_spec.rb: assert the $_db_notify database-rebuild gating in both directions -- a bare config edit with manage_database => false must NOT notify a rebuild, and with manage_database => true the managed aide.conf line must notify Exec[update_aide_db]. This central safety invariant was previously unasserted. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jul 7, 2026
The negative-direction assertion relied on `resource[:notify]` being nil, which passes for many unrelated reasons (undef is stripped at compile time) and is nearly tautological given the sibling `not_to contain_exec` check. Replace it with a first-class relationship matcher guarded by an existence assertion, since `not_to ...that_notifies` passes vacuously when the resource is absent. Also add a `database_in` negative context to cover a more common field edit alongside DBDIR; both lines share the same `notify => $_db_notify` wiring. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit-test hardening, split out of the original combined PR #168 per review feedback.
spec/classes/init_spec.rb: assert the$_db_notifydatabase-rebuild gating in both directions — a bare config edit withmanage_database => falsemust NOT notify a rebuild, and withmanage_database => truethe managedaide.confline must notifyExec[update_aide_db]. This central safety invariant was previously unasserted.Branches off
master; independent of the AGENTS.md and acceptance PRs (linked below).Related PRs (split from #168)