Cleanup for 8.0.0 release: migrate to 6.x stack and run acceptance under Vagrant - #154
Merged
Conversation
- Point issues_url at GitHub Issues - Allow simp-rsyslog 9.x, simp-simplib 5.x, simp-stunnel 8.x
- Drop EOL nodesets (centos8, rhel7, oel.yml versionless, amzn2, etc.) - Add vagrant nodesets for AlmaLinux, CentOS Stream, Oracle Linux, RHEL, Rocky Linux 8/9/10 - Update default.yml to use AlmaLinux 9 + openvox8
Docker covers the full supported-OS matrix; vagrant would only run against AlmaLinux 9/10 in GitHub Actions due to runner memory limits.
The docker acceptance suites failed across the entire OS matrix on the old
5.25.x stack ('Systemd start for rsyslog failed!' in-container); the
6.x/simp-beaker-helpers 3.1 stack provisions the systemd-enabled container
correctly and the suites pass.
- simp-rake-helpers ~> 6.0 / simp-beaker-helpers ~> 3.1; drop
puppetlabs_spec_helper for voxpupuli-test/puppet_fixtures; drop the legacy
'#{source_dir}' fixtures symlink; rubocop ~> 1.85 / rubocop-rspec ~> 3.9
- puppet-lint top-scope ($::) autofixes from the stricter plugins
- Disable Style/OneClassPerFile for the acceptance Utils helper (its nested
namespace requires forward-declaring parent modules in one file)
Validated locally on docker: almalinux 8/9/10 each 5 examples, 0 failures,
2 pending. Unit suite: 477 examples, 0 failures.
silug
force-pushed
the
cleanup-major-release
branch
from
July 4, 2026 17:12
decf895 to
0a38db2
Compare
The docker acceptance matrix ran under rootless podman in CI, where the
rsyslog systemd service (pulled in by rsync::server's drop_rsyslog_noise)
cannot start ('Systemd start for rsyslog failed!'), failing every OS. The
6.x migration alone was insufficient -- it passes under real Docker but not
rootless podman. Point the acceptance matrix at the Vagrant nodesets
(almalinux8/9/10), mirroring the other modules that need a real systemd
(e.g. pupmod-simp-simp_rsyslog).
Validated locally under Vagrant: almalinux8/9/10 each 5 examples,
0 failures, 2 pending.
silug
changed the title
The tag/release workflow still ran under Ruby 2.7.8 with PUPPET_VERSION '~> 7' (mapped to openvox ~> 7 by the Gemfile), which cannot resolve against simp-rake-helpers >= 6.0 (requires openvox >= 8 < 9). Align with the pr_tests openvox8 lane: Ruby 3.2.11 and PUPPET_VERSION '~> 8', so the tag & release jobs don't fail after merge.
nick-markowski
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 8.0.0 metadata cleanup, plus the test-stack migration and a correction to how acceptance is run.
Metadata cleanup
requirementspuppet→openvox(>= 8 < 9);issues_url→ GitHub IssuesTest stack migration
simp-rake-helpers ~> 6.0/simp-beaker-helpers ~> 3.1; voxpupuli-test/puppet_fixtures; droppuppetlabs_spec_helper;rubocop ~> 1.85Style/OneClassPerFilefor the acceptanceUtilshelper (its nested namespace forward-declares parent modules in one file)Acceptance: docker → Vagrant
The docker matrix ran under rootless podman in CI, where the
rsyslogsystemd service — pulled in byrsync::serverviadrop_rsyslog_noise— cannot start (Systemd start for rsyslog failed!), failing every OS. The migration alone was insufficient (it passes under real Docker but not rootless podman). Point the acceptance matrix at the Vagrant nodesets (almalinux8/9/10), matching the other modules that need a real systemd (e.g. pupmod-simp-simp_rsyslog).Validation (local Vagrant)
almalinux8/9/10 each: 5 examples, 0 failures, 2 pending · unit: 477 examples, 0 failures
🤖 Generated with Claude Code