Fix global catalyst name in README - #160
Conversation
|
|
||
| ``` | ||
| simp_options::rsync: 'fqdn.rsync.server' | ||
| simp_options::rsync::server: 'fqdn.rsync.server' |
There was a problem hiding this comment.
The "standard 'true' boolean value" sentence below suggests the original key was what's now simp::rsync_stunnel — a Variant[Boolean, Host] defaulting to true — rather than simp_options::rsync::server (a host string defaulting to 127.0.0.1).
It's also a functional difference when stunnel is in play, as this section assumes: rsync::retrieve connects directly to whatever simp_options::rsync::server names (no tunnel awareness), but the server's rsyncd binds 127.0.0.1 and only stunnel's TLS socket (:8730) is reachable externally — so a direct connection to the fqdn gets refused. simp::rsync_stunnel: re-points the client tunnel instead, which is also why the example above moves the local rsyncd to port 8873 (the client tunnel occupies 127.0.0.1:873).
suggestion
simp::rsync_stunnel: 'fqdn.rsync.server'
to override the default of true, which points the client's rsync tunnel at
the primary Puppet server.
If simp_options::rsync::server was deliberate (non-stunnel case), the trailing sentence still needs updating — that key's standard value is 127.0.0.1, not true. - Found via Claude so also maybe not a big issue.
No description provided.