Skip to content

Fix global catalyst name in README - #160

Open
op-ct wants to merge 1 commit into
simp:masterfrom
op-ct:fix/ancient-catalyst-name
Open

Fix global catalyst name in README#160
op-ct wants to merge 1 commit into
simp:masterfrom
op-ct:fix/ancient-catalyst-name

Conversation

@op-ct

@op-ct op-ct commented Aug 4, 2026

Copy link
Copy Markdown
Member

No description provided.

Comment thread README.md

```
simp_options::rsync: 'fqdn.rsync.server'
simp_options::rsync::server: 'fqdn.rsync.server'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "standard 'true' boolean value" sentence below suggests the original key was what's now simp::rsync_stunnel — a Variant[Boolean, Host] defaulting to true — rather than simp_options::rsync::server (a host string defaulting to 127.0.0.1).

It's also a functional difference when stunnel is in play, as this section assumes: rsync::retrieve connects directly to whatever simp_options::rsync::server names (no tunnel awareness), but the server's rsyncd binds 127.0.0.1 and only stunnel's TLS socket (:8730) is reachable externally — so a direct connection to the fqdn gets refused. simp::rsync_stunnel: re-points the client tunnel instead, which is also why the example above moves the local rsyncd to port 8873 (the client tunnel occupies 127.0.0.1:873).

suggestion
simp::rsync_stunnel: 'fqdn.rsync.server'

to override the default of true, which points the client's rsync tunnel at
the primary Puppet server.

If simp_options::rsync::server was deliberate (non-stunnel case), the trailing sentence still needs updating — that key's standard value is 127.0.0.1, not true. - Found via Claude so also maybe not a big issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

2 participants