Replace legacy facts with structured facts - #381
Merged
Merged
Conversation
- simp::puppetdb computes percentage-based Java heap sizes from $facts['memory']['system']['total_bytes'] in native Puppet instead of an inline ERB template using the legacy memorysize_mb fact; behavior is unchanged (verified with new unit assertions for both the percentage and absolute-value forms) - Acceptance suites query networking.* structured facts instead of the flat fqdn, domain, ipaddress_eth1, and macaddress_eth1 facts The bootstrap_simp_client spec's selinux stubs flagged in the issue are already structured os.selinux values and the templates were already fixed, so nothing else remained. Fixes #329 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XCnDsYaJDLiP8z8tafz9Tp
hcaballero2
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #329 (no other open PR addresses it — verified).
simp::puppetdb: the percentage-based Java heap computation moves from an inline ERB template using the legacymemorysize_mbfact to native Puppet using$facts['memory']['system']['total_bytes']. Behavior is identical (MiB × percent, rounded,msuffix; non-percentage values pass through verbatim) — locked in with new unit assertions for both forms, which pass across the OS matrix (379 examples, 0 failures on the puppetdb spec).fact_oncalls move to structured facts —networking.fqdn,networking.domain,networking.interfaces.eth1.ip/.mac— replacing the flatfqdn/domain/ipaddress_eth1/macaddress_eth1facts.Two items from the issue's listing needed no change: the
bootstrap_simp_clientspec stubs are already structuredos.selinuxvalues (matching what the script reads viaFacter.value(:os).dig('selinux', ...)), and the kickstart templates were already fixed to@facts['networking']['domain']on master. A final sweep ofmanifests/,lib/,templates/, andspec/acceptance/finds no remaining flat-fact usage.Rides the unreleased 9.0.0 (CHANGELOG entry added; no additional bump needed). syntax/lint/rubocop/validate:strings/RELENG all pass locally.
🤖 Generated with Claude Code