Remove deprecated and archived-module functionality for 9.0.0 - #382
Open
hcaballero2 wants to merge 7 commits into
Open
Remove deprecated and archived-module functionality for 9.0.0#382hcaballero2 wants to merge 7 commits into
hcaballero2 wants to merge 7 commits into
Conversation
The simp_options::clamav catalyst has been deprecated since simp_options 1.4.0 (2019) and simp::server promised its removal in a future release. Drop the clamav param and conditional include from simp::server, the clamav rsync share section, and the catalyst from acceptance hieradata. To manage ClamAV, include the clamav class directly in the class list. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
pupmod-simp-sudosh is archived. Narrow simp::admin::logged_shell to Enum['tlog'] so sites still setting 'sudosh' fail loudly at compile time instead of silently flipping to tlog. The sudosh2 profile-script cleanup resources are retained so upgrading systems still get leftovers purged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Remove the metadata dependencies and fixtures for simp/sudosh, simp/chkrootkit, and simp/simp_openldap (all archived) and simp/clamav (no longer referenced). chkrootkit and simp_openldap had no remaining code references at all. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
simp::ldap flowed only to simp::scenario::base::ldap, which was never used. The live simp_options::ldap lookup in simp::sssd::client is unaffected. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…r release - simp::enable_data_includes (no-op) - simp::puppetdb::read_database_ssl (use read_database_jdbc_ssl_properties) - simp::yum::repo::internet_simp_server and internet_simp_dependencies (use simp::yum::repo::internet_simp) - simp::server::kickstart::manage_runpuppet (runpuppet was replaced by simp_client_bootstrap) - simp::base_services (shim for simp::base_apps; also removed from the scenario class lists) - simp::base_apps::manage_elinks_config (declared but unused) - simp::sysctl::kernel__exec_shield (declared but unused; the kernel dropped this sysctl) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Extend the 9.0.0 CHANGELOG entry, update the AGENTS.md class/dependency/ seam summaries, and regenerate REFERENCE.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The 'ldap => true/false' sub-contexts passed the removed $simp::ldap parameter directly to the class, which now fails compilation. The IPA membership compile check and the simp_openldap::client exclusion they were proving are kept as a single context. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit follow-up to #380: since 9.0.0 is a major bump, this sweeps out everything already marked deprecated or referencing archived modules — the
simp_options::clamavcatalyst (deprecated since 2019) and its rsync share, sudosh support insimp::admin(logged_shellis nowEnum['tlog']so sudosh sites fail loudly instead of silently flipping), dependencies on archivedsimp/sudosh/simp/chkrootkit/simp/simp_openldap(and unarchived-but-unusedsimp/clamav), the never-consumedsimp::ldapparameter chain, and the items previously promised for removal at the next major release (enable_data_includes,puppetdb::read_database_ssl, theinternet_simp_server/internet_simp_dependenciesyum classes,kickstart::manage_runpuppet,simp::base_services, plus the unusedmanage_elinks_configandkernel__exec_shieldparams). See the CHANGELOG for the full BREAKING CHANGE list.🤖 Generated with Claude Code