Remove deprecated simp_options::ntpd class - #129
Merged
Conversation
pupmod-simp-ntpd has been archived, so delete the deprecated simp_options::ntpd class, its include in simp_options::init, its spec and hieradata fixture, and its REFERENCE.md sections. Point the shared init_spec expectation at simp_options::ntp, which is unchanged. Breaking change: bump to 3.0.0 with a hieradata migration note in the CHANGELOG. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
silug
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the deprecated
simp_options::ntpdclass now thatpupmod-simp-ntpdhas been archived:manifests/ntpd.ppis deleted along with itsincludeinsimp_options::init, its spec, and its hieradata fixture, andREFERENCE.md/CHANGELOGare updated to match. This is a breaking change (major bump to 3.0.0): sites that setsimp_options::ntpd::serversin hieradata must rename the key tosimp_options::ntp::servers, which is what the chrony wiring and (as of simp/pupmod-simp-simp#380) the SIMP client kickstart consume.simp_options::ntpitself is untouched. Fixes #126.🤖 Generated with Claude Code