You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Heads-up: the failing Puppet Style check is blocked upstream, not by this PR
The Puppet Style job fails because puppet-lint 4.x crashes on Ruby 3.4 — it raises NoMethodError: undefined method '[]' for nil in PuppetLint::Data.tokens (via parse_control_comments) on any commented .pp file. Reproduced in a ruby:3.4.9 container; 4.3.0 is the latest 4.x, so there's no 4.x fix.
puppet-lint5.1.1 fixes the crash, and the three lint plugins have compatible ~> 3.0 releases. However, it can't be installed here:
Because puppetlabs_spec_helper >= 6.0.2 depends on puppet-lint ~> 4.0
and Gemfile depends on puppetlabs_spec_helper ~> 8.0.0,
puppet-lint ~> 4.0 is required.
So, because Gemfile depends on puppet-lint ~> 5.1, version solving has failed.
puppetlabs_spec_helper 8.0.0 (its latest release) hard-pins puppet-lint ~> 4.0. That — not pdk, which already allows puppet-lint < 6.0 — is the binding constraint.
Status: blocked / on hold
This needs puppetlabs_spec_helper to ship a release that allows puppet-lint 5 (or to be dropped/replaced) before the Ruby 3.4 bump can land cleanly.
Interim options if it becomes urgent:
Pin only the Puppet Style job to Ruby 3.3.x (puppet-lint 4.3.0 runs fine there); everything else moves to 3.4.9.
Run lint from a separate Gemfile that excludes puppetlabs_spec_helper, with puppet-lint ~> 5.1 + the ~> 3.0 plugins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
3.4.9→3.4.103.2.11→3.4.10Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.