Skip to content

Pull RPM build containers from ghcr.io/simp/simp-<os>-build (fixes fleet-wide RPM build failures) #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
silug wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Pull RPM build containers from ghcr.io/simp/simp-<os>-build (fixes fleet-wide RPM build failures) #48

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f01e8b3
Pull RPM build containers from ghcr.io/simp/simp-<os>-build
silug Jul 28, 2026
9c56ec0
Add CHANGELOG entry for the ghcr build container switch
silug Jul 28, 2026
ea957dc
Drop CHANGELOG.md hunk per the changelog freeze
silug Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions modules/profile/files/_github/workflows/release_rpms.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,11 @@ on:
build_container_os:
description: "Build container OS"
required: true
default: 'centos8'
default: 'el8'

@hcaballero2 hcaballero2 Jul 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the valid values are now exactly el8/el9/el10, consider making this a type: choice input:

      build_container_os:
        description: "Build container OS"
        required: true
        type: choice
        options: [el8, el9, el10]
        default: 'el8'

With free text, anyone dispatching with old muscle memory (centos8, centos7) gets ghcr.io/simp/simp-centos7-build:latest — a nonexistent image whose pull failure only surfaces deep inside the build/signing job. This isn't hypothetical: simplib's most recent release_rpms run (29344542051, 2026-07-14) was dispatched with build os: centos7. choice also works fine for the cross-repo target_repo dispatch path (the API rejects values outside options, which is the point). If you'd rather keep it free-text for forward-compat with future ELs, at least name the valid values in the description.

build_container_tag:
description: "Build container tag"
required: true
default: 'latest'
target_repo:
description: "Target repo (instead of this one)"
required: false
Expand Down Expand Up @@ -253,7 +257,7 @@ jobs:
gpg_signing_key_id: ${{ secrets.SIMP_DEV_GPG_SIGNING_KEY_ID }}
gpg_signing_key_passphrase: ${{ secrets.SIMP_DEV_GPG_SIGNING_KEY_PASSPHRASE }}
simp_core_ref_for_building_rpms: ${{ secrets.SIMP_CORE_REF_FOR_BUILDING_RPMS }}
simp_builder_docker_image: 'docker.io/simpproject/simp_build_${{ github.event.inputs.build_container_os }}:latest'
simp_builder_docker_image: 'ghcr.io/simp/simp-${{ github.event.inputs.build_container_os }}-build:${{ github.event.inputs.build_container_tag }}'
path_to_build: "${{ (github.event.inputs.path_to_build != null && format('{0}/{1}', github.workspace, github.event.inputs.path_to_build)) || github.workspace }}"
verbose: 'no' #${{ github.event.inputs.verbose }}

Expand Down