Replace puppetlabs_spec_helper with puppet_fixtures (Ruby 4.0 support) - #283
Merged
Merged
Conversation
silug
force-pushed
the
replace-puppetlabs-spec-helper
branch
2 times, most recently
from
June 24, 2026 22:13
d7d275b to
a0e268a
Compare
silug
marked this pull request as draft
June 24, 2026 22:24
nick-markowski
previously approved these changes
Jun 25, 2026
silug
force-pushed
the
replace-puppetlabs-spec-helper
branch
from
June 25, 2026 13:36
a0e268a to
aa6f9c5
Compare
Dropping Puppet 7 / Ruby 2.7 support is a breaking change, so bump to 3.0.0. simp-beaker-helpers required `puppetlabs_spec_helper/tasks/fixtures` for its fixture rake tasks. puppetlabs_spec_helper pulls in puppet-syntax < 5, which depends on the `puppet` gem and its `facter` dependency, and `facter` does not support Ruby >= 4.0 -- so anything depending on simp-beaker-helpers (e.g. simp-rake-helpers) could not run on Ruby 4. - Replace `puppet_fixtures` for `puppetlabs_spec_helper/tasks/fixtures`; the beaker:suites task depends on 'fixtures:prep' and ensure_fixture_modules runs 'rake fixtures:prep'. Declare puppet_fixtures as a runtime dependency. - Drop the Puppet 7.x / Ruby 2.7 entries from the pr_tests and pr_acceptance matrices, and relabel the remaining matrix entries to OpenVox 8.x (they already install the openvox gem). CI now tests OpenVox 8 only. - Raise the default OpenVox gem floor to >= 8.0.0; point tag_deploy at '~> 8'. - get_puppet_install_info now honours OpenVox-named env vars (OPENVOX_VERSION, BEAKER_OPENVOX_COLLECTION, etc.) with precedence over the Puppet-named equivalents, which remain as fallbacks. Verified: specs pass (23 examples) and the fixtures:prep/fixtures:clean/ beaker:suites tasks load on Ruby 3.2 and Ruby 4.0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
silug
marked this pull request as ready for review
June 25, 2026 13:48
silug
force-pushed
the
replace-puppetlabs-spec-helper
branch
from
June 25, 2026 13:48
aa6f9c5 to
c805dfa
Compare
nick-markowski
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simp-beaker-helpers required
puppetlabs_spec_helper/tasks/fixturesfor its fixture rake tasks. puppetlabs_spec_helper pulls in puppet-syntax < 5, which depends on thepuppetgem and itsfacterdependency, andfacterdoes not support Ruby >= 4.0 -- so anything depending on simp-beaker-helpers (e.g. simp-rake-helpers) could not run on Ruby 4.Switch to
puppet_fixtures, the OpenVox-ecosystem fixtures gem (used by voxpupuli-test), which supports Ruby 4.0:Verified: specs pass and the fixtures:prep/fixtures:clean/beaker:suites tasks load on Ruby 3.2 and Ruby 4.0.