Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ group :syntax do
gem 'rubocop', '~> 1.87.0'
gem 'rubocop-performance', '~> 1.26.0'
gem 'rubocop-rake', '~> 0.7.1'
gem 'rubocop-rspec', '~> 3.7.0'
gem 'rubocop-rspec', '~> 3.10.0'
end

group :test do
Expand Down
8 changes: 4 additions & 4 deletions spec/acceptance/suites/default/10_updaterepos_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
# @fails if the specified repo file cannot be installed on host
def copy_repo(_host, repo_filename, repo_name = 'simp_manual.repo')
raise("File #{repo_filename} could not be found") unless File.exist?(repo_filename)
puts('=' * 72)
puts("Using repos defined in #{repo_filename}")
puts('=' * 72)
puts('=' * 72) # rubocop:disable RSpec/Output
puts("Using repos defined in #{repo_filename}") # rubocop:disable RSpec/Output
puts('=' * 72) # rubocop:disable RSpec/Output
scp_to(hosts, repo_filename, "/etc/yum.repos.d/#{repo_name}")
end

Expand Down Expand Up @@ -132,7 +132,7 @@ def set_up_local_repo(host, repo_name)
hosts.each do |host|
os_major = fact_on(host, 'os.release.major')
if os_major == '8'
puts 'SKIPPING test because SIMP repositories for EL8 are not set up: SIMP-9143'
puts 'SKIPPING test because SIMP repositories for EL8 are not set up: SIMP-9143' # rubocop:disable RSpec/Output
next
end

Expand Down
6 changes: 3 additions & 3 deletions spec/acceptance/suites/default/20_openldap_to_389ds_spec.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
require 'spec_helper_acceptance'
describe 'OpenLDAP to 389DS convert and import scripts' do
ldap_server = only_host_with_role(hosts, 'ldap_server')
ldap_server_fqdn = fact_on(ldap_server, 'networking.fqdn')
let(:ldap_server) { only_host_with_role(hosts, 'ldap_server') }
let(:ldap_server_fqdn) { fact_on(ldap_server, 'networking.fqdn') }

let(:files_dir) { File.join(File.dirname(__FILE__), 'files', 'openldap_to_389ds') }
let(:scripts_src) { 'share/transition_scripts/openldap_to_389ds' }
Expand Down Expand Up @@ -126,7 +126,7 @@
end
end

context "Executing importer script on #{ldap_server}" do
context 'Executing importer script on ldap_server' do
let(:ds_root_name) { 'accounts' }
let(:hieradata) do
{
Expand Down
2 changes: 1 addition & 1 deletion spec/scripts/bin/unpack_dvd_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def tmpdir

Dir.glob(File.join(__dir__, 'files', 'unpack_dvd', 'ISO', '*')).each do |target|
next unless File.directory?(target)
target_name = File.basename(target)
target_name = File.basename(target) # rubocop:disable RSpec/LeakyLocalVariable

context "when unpacking an ISO for #{target_name}" do
let(:working_dir) { File.join(tmpdir, target_name) }
Expand Down