Feature/numpy2 #90
Open
Feature/numpy2 #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change is compatible with numpy<2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Adds compatibility with
numpy>2while keeping compatibility withnumpy<2Fixes
Implements #87 #86: It seems it was enough to replace
np.fromstringwithnp.frombuffer, tested fornumpy < 2andnumpy > 2.Pytests were also updated (np.bool -> np.bool_) to be compatible with
numpy < 2andnumpy > 2To test
I could not pass server tests, but I don't think that is relevant to this PR,
dataclasstests pass. I also tested by remotely getting data from JET ppfs. It worked and the data made sense.Reviewer checklist