Skip to content

Fix moshi enum obfuscation #5937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siddh1004 merged 2 commits into from
Sep 21, 2026
Merged

Fix moshi enum obfuscation #5937

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf56663
Fix Moshi enum obfuscation
Sep 18, 2026
e2c019f
Enable R8 obfuscation for production builds
Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions app/proguard-rules.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# No obfuscation because open source
# We depend on the convention of generated DAO names by Room in order to support performance profiling.
# If you decide to obfuscate the final APK, please verify the performance profiling tool continues to function.
# We obfuscate the final APK while keeping generated Room DAO names unchanged.
# We depend on the convention of generated DAO names by Room to support performance profiling.
# If you modify this rule, please verify that the performance profiling tool continues to function.
# See: https://github.com/simpledotorg/simple-android/issues/2470
-dontobfuscate
-keepnames class **_RoomDao_Impl

# We process generated Room DAO metadata and use a runtime exception for performance profiling.
# If you remove this, please ensure that the profiling does not break.
Expand Down Expand Up @@ -46,6 +46,12 @@
<fields>;
}

# SyncProgress is serialized by Moshi's reflective EnumJsonAdapter.
# Keep enum field names unchanged so Moshi can resolve them by reflection.
-keepclassmembers enum org.simple.clinic.sync.SyncProgress {
<fields>;
}

# The name of @JsonClass types is used to look up the generated adapter.
-keepnames @com.squareup.moshi.JsonClass class *

Expand Down
Loading