Separate in container scripts#1
Open
henryaddison wants to merge 4 commits into
Open
Conversation
Mainly to cut down on spinning up new containers for each command
including correcting the link to the cddeploy script as expected by the link text
this should all happen only in the docker image build
henryaddison
force-pushed
the
separate-in-container-scripts
branch
from
e08877b to
fcb3c0f
Compare
otherwise shellcheck tries to scan the docker item and fails because it's a directory not a script
henryaddison
force-pushed
the
separate-in-container-scripts
branch
from
fcb3c0f to
db52fc0
Compare
Contributor
Author
|
@ollieh-m You might be interested in some changes to these scripts based on our findings from Landmrk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found these scripts ran slowly in Landmrk in part due to spinning up a lot of containers. Attempting to reduce the number of containers started by having separate scripts to be run inside a container rather than individual commands executed by
docker-compose run.Plus a bit of tidying: README corrections and no need to install gems locally as using docker to run the app.