Skip to content

trying to make /setting work #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PacoRoberto9 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

trying to make /setting work #2

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
00b2c29
Update setting.js
PacoRoberto9 Oct 23, 2023
928527f
Update setting.js
PacoRoberto9 Oct 23, 2023
b5b0b49
Update setting.js
PacoRoberto9 Oct 23, 2023
d028b25
Update setting.js
PacoRoberto9 Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/junon-io/server/commands/setting.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,7 @@ class Setting extends BaseCommand {
return
}

if (!this.sector.settings[key]) {
player.showChatError("invalid key. Valid keys are: " + Object.keys(this.sector.settings).join(", "))
return
}


if (["true", "false"].indexOf(value) === -1) {
player.showChatError("invalid value. true/false accepted only")
return
Expand All @@ -54,6 +50,11 @@ class Setting extends BaseCommand {
if (value === 'true') value = true
if (value === 'false') value = false

if (this.sector.settings[key] === undefined || this.sector.settings[key] === null) {
player.showChatError("invalid key. Valid keys are: " + Object.keys(this.sector.settings).join(", "))
return
}

this.sector.editSetting(key, value)
player.showChatSuccess(key + " set to " + value)
}
Expand Down