-
Notifications
You must be signed in to change notification settings - Fork 217
New lightgrep #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
simsong
wants to merge
32
commits into
main
Choose a base branch
from
new-lightgrep
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
New lightgrep #486
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
43f5303
R - delete lightgrep scanners not ported, edit Makefile.am accordingly
juliapal 287b882
F - skeleton of new lightgrep scanner for BE2.0
juliapal dc034c8
R - comment out unused phases
juliapal d638a2a
F!! - initialization of Lightgrep Controller
juliapal 8ecacd1
R - If PHASE_INIT2 happens >1, Get() causes Fsm to be empty on subseq…
juliapal ee7b242
F - simplify addUserPatterns for now
juliapal 7e1eefa
F - make regcomp, gotHit, HitData, and scan work with new skeleton
juliapal c629d3a
R - Prog may not be initialized before numPatterns is called
juliapal 72c69a8
R - fix declarations
juliapal 99bc030
F - Append lightgrep feature recorder to feature defs
juliapal 1c1c4d0
Delete unused scanner
juliapal 4579d9c
give write_buf good args
juliapal 7553305
Result is positive upon success
juliapal a3616e0
F!! enable mulitple patterns passed through CLI
juliapal 5097c1c
F - add user_files param to addUserPatterns to avoid scanner config a…
juliapal 92b7f75
F - Handle user files with parsed patterns in lightgrep scanner
juliapal c553d2b
Remove unused or commented code
juliapal 707466b
b - lightgrep should run even if find is disabled
juliapal 48b9ca3
F - enable histogram for lightgrep
juliapaluch e7ac804
get rid of comments & unused code
juliapaluch 8cdc2f1
F - delete Fsm if not deleted by regcomp
juliapaluch bb88ad8
b - don't declare initScan
juliapaluch 90bb108
F - remove Scanner "global" variable
juliapaluch 8c143b3
remove unused includes
juliapaluch f553e62
F - throw exception when lightgrep fails to parse pattern
juliapaluch 799221b
better error messages
juliapaluch 0ca43ec
F - avoid unnecessary repeated heap alloc/dealloc
juliapaluch 007b9c9
F!! - Reverting use of thread local because it seems to cause a perfo…
juliapaluch fb0e42e
F - update scanner name and version
juliapaluch 5e55041
a - Delete superfluous whitespace
juliapaluch 16e8eeb
a - formatting, fix inaccurate comments
juliapaluch ae97fa7
Merge pull request #421 from juliapaluch/lightgrep-compat
simsong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg_add_pattern_list()seems able to return -1 without populating the error chain, so this function can return false without printing a more descriptive error message.lg_add_pattern_list()needs more unit testing in lightgrep...