DEVEXP-794: Conversation - Messages (Endpoint Unit Tests) #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asein-sinch
reviewed
Jan 16, 2026
Contributor
asein-sinch
left a comment
asein-sinch
left a comment
There was a problem hiding this comment.
Overall, I think these tests can be simplified:
- testing the parameters => keep
- testing the response => simplify the response with only the required parameters (still check the 2 variants of the
oneOf) and remove the assertions regarding all the attributes (this can go to the unit tests, written once)
tests/unit/domains/conversation/v1/endpoints/messages/test_delete_message_endpoint.py
Outdated
Show resolved
Hide resolved
tests/unit/domains/conversation/v1/endpoints/messages/test_get_message_endpoint.py
Outdated
Show resolved
Hide resolved
tests/unit/domains/conversation/v1/endpoints/messages/test_update_message_endpoint.py
Outdated
Show resolved
Hide resolved
tests/unit/domains/conversation/v1/endpoints/messages/test_update_message_endpoint.py
Outdated
Show resolved
Hide resolved
tests/unit/domains/conversation/v1/endpoints/messages/test_update_message_endpoint.py
Outdated
Show resolved
Hide resolved
tests/unit/domains/conversation/v1/endpoints/messages/test_update_message_endpoint.py
Outdated
Show resolved
Hide resolved
asein-sinch
approved these changes
Jan 16, 2026
Contributor
asein-sinch
left a comment
asein-sinch
left a comment
There was a problem hiding this comment.
I think the content of the JSON response can be reduced again, as well as the assertions. Up to you, the PR is approved anyway 🙌
Contributor
Author
|
Yes, I will reduce the payload in the next PR :D |
matsk-sinch
deleted the
DEVEXP-794_Conversation-Messages-Endpoint-Test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.