Fix truncation exceeding maxWidth for wide characters#29
Closed
RyogaK wants to merge 1 commit into
Closed
Conversation
sliceAnsi rounds up when the slice boundary falls inside a wide (CJK) character, causing the result to exceed the specified columns. Add a safeSliceAnsi wrapper that re-slices with a 1-column narrower range when this happens. Workaround for chalk/slice-ansi#43 Fixes #28
Author
|
CI failure is unrelated to this PR — |
Author
|
The |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cliTruncateoutput exceedscolumnswhen the truncation boundary falls inside an East Asian wide (CJK) charactersafeSliceAnsiwrapper that re-slices with a 1-column narrower range whensliceAnsirounds upend,start,middle)Test plan
stringWidth(result) <= maxWidthfor all widths 1–25 across all three positions with CJK input