Cover align-GCIMSSample.R and utils-io-mea.R edge cases; fix wrong unit in read_mea() error - #51
Merged
Merged
Conversation
…it in read_mea() error align-GCIMSSample.R: tests the all-NA-before-subsetting aborts in align() and prealign() (the latter forced via local_mocked_bindings, since alignDt()/subset.GCIMSSample() can't naturally produce an all-NA result through the public API), and the dt_max_ms/rt_max_s high-end truncation branches in alignDt()/alignRt_ptw() (triggered with a correction that shrinks, rather than grows, the axis). utils-io-mea.R: tests read_mea()'s extension guard, named-filename description, and its Chunk-sample-rate/Chunk-trigger-repetition/drift-tube unit validation branches, using a fixture that patches individual header lines of the bundled small.mea.gz sample and re-serializes a synthetic .mea file with the same binary data. Also tests write_mea()'s filename validation and its .mea.gz/extension-appending branches. Fixes a copy-paste bug found via the above: the "Chunk trigger repetition" unit-validation error reported params[["Chunk sample rate"]]'s unit (always "kHz") instead of the actual invalid unit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
align-GCIMSSample.R: tests the all-NA-before-subsetting aborts in align()
and prealign() (the latter forced via local_mocked_bindings, since
alignDt()/subset.GCIMSSample() can't naturally produce an all-NA result
through the public API), and the dt_max_ms/rt_max_s high-end truncation
branches in alignDt()/alignRt_ptw() (triggered with a correction that
shrinks, rather than grows, the axis).
utils-io-mea.R: tests read_mea()'s extension guard, named-filename
description, and its Chunk-sample-rate/Chunk-trigger-repetition/drift-tube
unit validation branches, using a fixture that patches individual header
lines of the bundled small.mea.gz sample and re-serializes a synthetic
.mea file with the same binary data. Also tests write_mea()'s filename
validation and its .mea.gz/extension-appending branches.
Fixes a copy-paste bug found via the above: the "Chunk trigger repetition"
unit-validation error reported params[["Chunk sample rate"]]'s unit
(always "kHz") instead of the actual invalid unit.