fix(layout): bound the grid tracks so wide content cannot widen the shell - #15
Merged
Merged
Conversation
…hell The chat overflow persisted after the previous attempt because I fixed the wrong layer. min-width:0 on .chat-messages / .chat-msg was correct in principle but irrelevant: the overflow originates ABOVE them. A `1fr` grid track has an automatic minimum of min-content, so a track cannot shrink below its widest descendant. One wide markdown table therefore forced the content column past the viewport, and every descendant inherited the over-wide box. .content (overflow:hidden, min-width:0) and .ws-panel (min-width:0) were already correct — the constraint simply never reached them. Bounded with minmax(0, ...): .view-shell sidebar + content column .ws-grid-single columns and rows .ws-grid-split-2x1 columns, rows .ws-grid-split-1x2 columns, rows .ws-grid-t-top columns, rows This is also why single-pane looked WORSE than split: the content column is the full window there, so the overrun ran off screen entirely instead of being bounded by the neighbouring pane. Also removes the overflow-x:hidden I added to .chat-messages last time. It hid the symptom and made it worse — the text was clipped with no way to scroll to what was cut off. With the tracks bounded, a wide table scrolls inside its own box (.chat-msg-body table) as originally intended. The visual.spec.ts pixel baselines cover the app shell, so a regression here is catchable in CI in a way the sidebar flash never was.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chat overflow persisted after the previous attempt because I fixed the
wrong layer. min-width:0 on .chat-messages / .chat-msg was correct in principle
but irrelevant: the overflow originates ABOVE them.
A
1frgrid track has an automatic minimum of min-content, so a track cannotshrink below its widest descendant. One wide markdown table therefore forced
the content column past the viewport, and every descendant inherited the
over-wide box. .content (overflow:hidden, min-width:0) and .ws-panel
(min-width:0) were already correct — the constraint simply never reached them.
Bounded with minmax(0, ...):
.view-shell sidebar + content column
.ws-grid-single columns and rows
.ws-grid-split-2x1 columns, rows
.ws-grid-split-1x2 columns, rows
.ws-grid-t-top columns, rows
This is also why single-pane looked WORSE than split: the content column is the
full window there, so the overrun ran off screen entirely instead of being
bounded by the neighbouring pane.
Also removes the overflow-x:hidden I added to .chat-messages last time. It hid
the symptom and made it worse — the text was clipped with no way to scroll to
what was cut off. With the tracks bounded, a wide table scrolls inside its own
box (.chat-msg-body table) as originally intended.
The visual.spec.ts pixel baselines cover the app shell, so a regression here is
catchable in CI in a way the sidebar flash never was.
Opened automatically after the
tierscheck passed on5a27c435.The check is attached to this branch head, so this is mergeable now.