Skip to content

Improve multilingual name display fallbacks#366

Open
apodacaduron wants to merge 7 commits into
mainfrom
improvements-to-name-display
Open

Improve multilingual name display fallbacks#366
apodacaduron wants to merge 7 commits into
mainfrom
improvements-to-name-display

Conversation

@apodacaduron

Copy link
Copy Markdown
Contributor

Description

Follow-up to #363. DualField.js always defaulted to the English input even when only Arabic had a value — now it picks the correct default (and self-corrects once if data loads async, without breaking manual toggling). The actors list "Name" column now reuses UniField to show/toggle both languages instead of English-only. Added .stop to UniField's toggle button so clicking it inside a table row doesn't also trigger the row click.

How to Test

  • Edit an actor with only name_ar set, no English — reopening the dialog should default to the Arabic input, not empty English.
  • In the Actors list, find an actor with both names set — the Name column should show one language with a globe icon to toggle to the other, without triggering the row click.
  • Confirm actors with only one language still display normally.

Jira ID (if applicable)

[e.g., BYNT-123]

@apodacaduron apodacaduron self-assigned this Jul 15, 2026
@apodacaduron
apodacaduron requested a review from level09 as a code owner July 15, 2026 14:02
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 20a5d710-d047-4415-9b89-c37e99c45f43

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch improvements-to-name-display

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@apodacaduron
apodacaduron marked this pull request as draft July 15, 2026 14:11
@apodacaduron apodacaduron changed the title Fix DualField default language and show both actor names in list Improve multilingual name display fallbacks Jul 15, 2026
@apodacaduron
apodacaduron marked this pull request as ready for review July 15, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant