Skip to content

Add translated titles to location admin levels and location types#370

Open
level09 wants to merge 5 commits into
mainfrom
feat/location-lookups-translations
Open

Add translated titles to location admin levels and location types#370
level09 wants to merge 5 commits into
mainfrom
feat/location-lookups-translations

Conversation

@level09

@level09 level09 commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add title_tr to location_admin_level and location_type (the only two lookup lists with no secondary-language support)
  • Alembic migration b6e3d1a8f254 also merges the two open migration heads on main (68396035f041, c7d2e9f4a1b8)
  • Expose the field in to_dict/from_json, validation models, and the component-data admin tables (same Translated Title column and editing the other lookup lists already have)
  • Typeahead endpoints for both lists now match the translated title too, consistent with Search translated titles in lookup typeahead endpoints #365

Test plan

  • flask db upgrade applies cleanly and resolves to a single head
  • Component data -> Location Administrative Levels / Location Types: Translated Title column visible and editable, round-trips on save
  • GET /admin/api/location-types/?q=<arabic> matches once translations are entered

@level09
level09 requested a review from apodacaduron as a code owner July 19, 2026 10:33
@level09 level09 self-assigned this Jul 19, 2026
@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 12b4b4bc-d992-4943-811b-a40e80d092a8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/location-lookups-translations

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@apodacaduron

Copy link
Copy Markdown
Contributor

Note: title_tr does get saved correctly but it's not rendered anywhere else in the ui

@apodacaduron apodacaduron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: title_tr does get saved correctly but it's not rendered anywhere else in the ui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants