Guard against multiple Alembic heads#374
Open
level09 wants to merge 1 commit into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
apodacaduron
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two branches that each add a migration both parent it on whatever was
headat authoring time. Git merges them cleanly because they touch different files, so the break only surfaces asMultiple head revisions are presentwhenflask db upgraderuns on deploy. This happened on #358 and would have failed mid-deploy.Three small pieces:
tests/test_migrations.pyasserts a single head. Runs in the existing pytest job, needs no database, ~0.1s. A PR that is individually fine but breaks aftermainmoves under it now goes red instead of reaching a server.flask doctorreported this case as a yellow! Could not check migrationsbecauseget_current_head()raises on multiple heads and the bareexceptswallowed it. Switched toget_heads()and made it a hard failure.CONTRIBUTING.mddocuments when to re-parent vs when toflask db merge heads.Before and after on a simulated two-head branch:
How to test
uv run pytest tests/test_migrations.pypasses on a clean tree.down_revisionpointing at any non-head revision, re-run, confirm it fails naming both heads.uv run flask doctorreports the failure line above.