Show label hierarchy paths in label previews by apodacaduron · Pull Request #379 · sjacorg/bayanat

apodacaduron · 2026-07-22T22:37:00Z

Summary

Labels can be nested, but pickers and chips only showed the leaf title, so same-named or generic labels (e.g. "Other") under different parents were indistinguishable. This adds path-aware label display:

New LabelSearchField (extends SearchField) — labels-only autocomplete using the compact mode=2 payload, showing parent path as a subtitle and a collapsed path on selected chips when the leaf is ambiguous.
New LabelPath.js — path utils + LabelPathChip/LabelPathTrail/LabelPathList, replacing flat label chips on bulletin/incident/actor cards and profiles. RTL-aware.
Swapped search-field → label-search-field everywhere labels/ver_labels are picked (bulletins, actors, incidents, review dialog, media import).

Note: card/profile views need a path field added to their serializers to actually show hierarchy — landing in a separate follow-up PR. Until then those views keep showing flat leaf chips.

Also: closes the incident drawer when editing an incident, to match bulletins/actors.

How to Test

Create a nested label (e.g. parent "Weapons", child "Firearms").
In a labels picker (bulletin/actor/incident), search for the child — confirm the dropdown shows it with the parent as a subtitle.
Select two same-named/generic labels under different parents — confirm the chip shows the parent path, not just the leaf.
Save and reopen the entity — confirm labels persist.
Switch UI to Arabic and repeat 2–3 — confirm path direction/order flips correctly.
Open an incident from the list — confirm the edit drawer closes.
Check console for errors on touched pages.

…path-improvements

Add label path support to SearchField-selected label pickers and enable path-aware label payloads across review, import, and search filter surfaces.

coderabbitai · 2026-07-22T22:37:07Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ea23f51e-4769-471b-8c22-284e329b5154

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch label-path-improvements

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

level09

Nice work, the new picker and the path chips are a good direction. Two things break real pages, and one ordering note:

The cards (bulletin / incident / actor profiles) are also used on the export dashboard, deduplication and import log pages. Those pages don't load LabelPath.js or register LabelPathList, so labels will show empty there.
Same problem on the activity page with label-search-field (details inline).
Merge order: the Arabic data (title_ar / path_ar in mode 2) comes from PR #369, so that one should go in first, then re-test Arabic here.

level09 · 2026-07-23T17:23:05Z

-                      {{ label.title }}
-                    </v-chip>
-                  </div>
+                  <label-path-list :labels="bulletin.labels"></label-path-list>


This card is also used on pages not touched by this PR (export dashboard, deduplication, import log). They don't register LabelPathList, so labels there render empty. Registering it inside the card itself (components: { LabelPathList }) protects every page, then those 3 pages just need the script tag.

level09 · 2026-07-23T17:23:06Z

  app.component('ActivitySearchBox', ActivitySearchBox);

  app.component('SearchField', SearchField);
+  app.component('LabelPathList', LabelPathList);


This page also renders the bulletin/actor/incident search boxes, which now use label-search-field, but it's not loaded or registered here, so the label filters on this page will be empty.

level09 · 2026-07-23T17:23:06Z

+      }
+      return window.LabelPathUtils.chipParts(item, this.selectedDuplicateLeaves);
+    },
+    debouncedSearch: debounce(function (search) {


I think you can delete this override and labelQueryParams: every caller already sends mode: 2, so a default value for the api prop is enough and the base SearchField does the rest.

level09 · 2026-07-23T17:23:06Z

+    return this.parentSegments(label, segments, 'ar');
+  },
+
+  parentSegments(label, segments = [], lang = this.primaryLang()) {


The backend path never includes the label itself, so this trimming never triggers on real data. Except one bad case: a child label with the same title as its parent (that's allowed) would lose its path. Safer to remove it.

level09 · 2026-07-23T17:23:06Z

+    const english = this.splitPath(label.path);
+    if (lang !== 'ar') return this.parentSegments(label, english, 'en');
+
+    const arabic = this.splitPath(label.path_ar || label.path_tr);


title_tr / path_tr don't exist on labels (that's the lookups model), these fallbacks can go.

level09 · 2026-07-23T17:23:06Z

@@ -0,0 +1,343 @@
+const LabelPathUtils = {
+  genericLeaves: new Set(['other', 'unknown', 'أخرى', 'آخر', 'غير معروف', 'غير معروفة']),


This word list will drift from real data ("misc", "N/A", other Arabic words...). The duplicate-leaf check already covers the ambiguous case, I'd drop the list.

level09 · 2026-07-23T17:23:06Z

+      >
+        <v-card-text class="pa-3">
+          <div class="text-overline font-weight-bold text-medium-emphasis mb-2">
+            LABEL PATH


Hardcoded English, same for "+N more" below. Should go through translations.

apodacaduron added 7 commits July 21, 2026 11:39

improvements

1064ccd

Merge branch 'main' of https://github.com/sjacorg/bayanat into label-…

9c54496

…path-improvements

Show compact label paths in pickers

b32de5f

Add label path support to SearchField-selected label pickers and enable path-aware label payloads across review, import, and search filter surfaces.

Separate label path picker from generic search field

64644bb

close drawer when editing incident to match bulletins and actors

a6cf959

remove debug shim from bulletins model

1220005

remove unneeded declaration

d122672

apodacaduron added 3 commits July 22, 2026 16:42

Simplify label path component wiring

752b467

Simplify label path rendering logic

8a9f88f

add comment to single item loop to call method only once

bc64135

apodacaduron self-assigned this Jul 23, 2026

apodacaduron added the project c label Jul 23, 2026

apodacaduron changed the title ~~Label path improvements~~ Show label hierarchy paths in label pickers Jul 23, 2026

apodacaduron marked this pull request as ready for review July 23, 2026 16:11

apodacaduron requested a review from level09 as a code owner July 23, 2026 16:11

apodacaduron changed the title ~~Show label hierarchy paths in label pickers~~ Show label hierarchy paths in label previews Jul 23, 2026

level09 reviewed Jul 23, 2026

View reviewed changes

apodacaduron added 4 commits July 23, 2026 11:41

Add translations for label path chip strings

9ba2fb0

Simplify LabelSearchField to rely on base SearchField

3c58ec6

Clean up label path utils and translate hardcoded strings

c1d6e31

Register label path components on pages that reuse the shared cards

ffd207e

apodacaduron requested a review from level09 July 23, 2026 21:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Show label hierarchy paths in label previews#379

Show label hierarchy paths in label previews#379
apodacaduron wants to merge 14 commits into
mainfrom
label-path-improvements

apodacaduron commented Jul 22, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jul 22, 2026 •

edited

Loading

Review skipped

Uh oh!

level09 left a comment

Uh oh!

level09 Jul 23, 2026

Uh oh!

level09 Jul 23, 2026

Uh oh!

level09 Jul 23, 2026

Uh oh!

level09 Jul 23, 2026

Uh oh!

level09 Jul 23, 2026

Uh oh!

level09 Jul 23, 2026

Uh oh!

level09 Jul 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -0,0 +1,343 @@
		const LabelPathUtils = {
		genericLeaves: new Set(['other', 'unknown', 'أخرى', 'آخر', 'غير معروف', 'غير معروفة']),

Uh oh!

Conversation

apodacaduron commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

How to Test

Uh oh!

coderabbitai Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

level09 left a comment

Choose a reason for hiding this comment

Uh oh!

level09 Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

level09 Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

level09 Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

level09 Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

level09 Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

level09 Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

level09 Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

apodacaduron commented Jul 22, 2026 •

edited

Loading

coderabbitai Bot commented Jul 22, 2026 •

edited

Loading