SPR1-1418: New beamformer raster scan script#446
Open
ludwigschwardt wants to merge 1 commit intomasterfrom
Open
SPR1-1418: New beamformer raster scan script#446ludwigschwardt wants to merge 1 commit intomasterfrom
ludwigschwardt wants to merge 1 commit intomasterfrom
Conversation
This electronically scans the beamformer across a source in a series of pointings. Each pointing lasts at least long as the delay model update rate, to ensure that it is properly set. This is typically used in conjunction with a custom SPEAD receiver that dumps the beamformer ingest signal display stream (1 Hz dump rate) to a file. It currently only steers beam `0x`, since the signal display only supports `0x` and `0y` anyway. This is the latest version used in the steerable beam tests on 22 September 2021.
spassmoor
requested changes
Nov 4, 2021
| session.cbf.req.set_beam_target('wide.tied-array-channelised-voltage.0x', target) | ||
| # user_logger.info(' (%s -> %s)', stream.name, target) | ||
| time_spent = time.time() - before | ||
| time.sleep(duration - time_spent) |
Contributor
There was a problem hiding this comment.
Since part of the function of the script is to change the phase centre after the beam weights/target has been set, there should be some logging here to report the time_spent setting them.
| user_logger.info('performing scan %d (%d pointings)', index, num_pointings) | ||
| session.activity('scan') | ||
| for x, y in zip(x_steps, y_steps): | ||
| mid_pointing = time.time() + pointing_duration / 2. |
Contributor
There was a problem hiding this comment.
This will be incorrect if the time_spent > pointing duration
| session.cbf.req.set_beam_target('wide.tied-array-channelised-voltage.0x', target) | ||
| # user_logger.info(' (%s -> %s)', stream.name, target) | ||
| time_spent = time.time() - before | ||
| time.sleep(duration - time_spent) |
Contributor
There was a problem hiding this comment.
Is the use of this script likely to have time_spent ~ pointing_duration . There would be no actual dwell time in this case
| for stream in session.cbf.beamformers: | ||
| if not stream.name.endswith('0x'): | ||
| continue | ||
| session.cbf.req.set_beam_target('wide.tied-array-channelised-voltage.0x', target) |
Contributor
There was a problem hiding this comment.
Is there any checking that this succeeds ? . I suppose the bumble on approach is the best way to deal with failure . Is failure reported as a log ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This electronically scans the beamformer across a source in a series
of pointings. Each pointing lasts at least long as the delay model
update rate, to ensure that it is properly set. This is typically used
in conjunction with a custom SPEAD receiver that dumps the beamformer
ingest signal display stream (1 Hz dump rate) to a file.
It currently only steers beam
0x, since the signal display onlysupports
0xand0yanyway. This is the latest version used in thesteerable beam tests on 22 September 2021.