Skip to content

Update angle normalization using remainder function #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skaae merged 1 commit into from
May 3, 2026
Merged

Update angle normalization using remainder function #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions mamba_ssm/ops/triton/mamba3/mamba3_mimo_rotary_step.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@ def rotary_qk_inference_kernel(
# Match angle_dt: tanh(angle_proj) * dt * pi
angle_proj = tl.sigmoid(2.0 * angle_proj) * 2.0 - 1.0 # tanh
angle = angle_state + angle_proj * dt * 3.141592653589793 # (rotary_dim // 2)
TWO_PI: tl.constexpr = 6.283185307179586
angle = angle - TWO_PI * tl.floor(angle / TWO_PI)

OUT_ANGLE_STATE = OUT_ANGLE_STATE + rd_half * stride_out_angle_state[2]
tl.store(OUT_ANGLE_STATE, angle, mask=mask_angle)
Expand Down Expand Up @@ -254,6 +256,7 @@ def apply_rotary_qk_inference_reference(
# Match angle_dt: tanh(angle_proj) * dt * pi
angle_proj = torch.tanh(angle_proj)
angle = angle_state + angle_proj * dt[:, :, None] * math.pi # (B, N, S)
angle = torch.remainder(angle, 2 * math.pi)
angle_state_new = angle
angle = angle.unsqueeze(1).expand(-1, mimo_dim, -1, -1) # (B, R, N, S)

Expand Down