This repository was archived by the owner on Sep 18, 2025. It is now read-only.
issues/205: consider full byte code when computing hashes#206
Closed
issues/205: consider full byte code when computing hashes#206
Conversation
pjmartos
approved these changes
Feb 23, 2025
| var classVisitor = new ClassVisitor(Opcodes.ASM9, classWriter) {}; | ||
| new ClassReader(inputStream).accept(classVisitor, ClassReader.SKIP_DEBUG); | ||
| return classWriter.toByteArray(); | ||
| return inputStream.readAllBytes(); |
There was a problem hiding this comment.
What about Files.readAllBytes(Path)? Both solutions would fail in case of reading a class that is way too large (> 2GiB), but Files.readAllBytes(Path) would fail early.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.