Draft
Conversation
Also update README GoDoc badge to pkg.go.dev.
In [1], from Go1.15 path separators are rejected in ioutil.TempFile. Refs sajari#87 [1] golang/go@12cd55c
It looks like the original author of this function intended to do a bounds check on the line variable before checking if it has the `### ` prefix. Instead, we can just use `strings.HasPrefix` which also means that shorter lines are now included in the output. Co-authored-by: Remo Senekowitsch <remo.senekowitsch@icloud.com>
We want to use testing.Cleanup which was added in 1.14.
Use table tests with current package value "", and "good". Co-authored-by: Remo Senekowitsch <remo@belegerfassung.ch>
* Use multi-stage build to compile docd * Bring debian variant up to date * Deprecate the alpine variant * Add GitHub action to publish an official image to DockerHub * Use published image as the AppEngine custom runtime
Co-authored-by: Helena Mariano <31138349+helenamariano@users.noreply.github.com>
Co-authored-by: Andrea Mugellini <a.mugellini@theswarm.co>
Also show Go version in startup logs.
- Some methods have been changed to return an error as their last argument - Log calls inside various functions have been removed - Use a v1 tag if you need the previous signature
Example log entry that is panicking: > could not write to response (failed after 3965 bytes): write tcp 172.17.0.5:8080->172.17.0.4:61528: write: broken pipe
See [my race fix PR]. Saw the issue in our logs, so using our fork for now. [my race fix PR]: richardlehane/msoleps#6
* Limit the size of the content type definition in OOXML * Improve naming in OOXML tests * Check OOXML error type in tests
* Bump to Alpine 3.17 * Build on PR. * Bump to Go 1.20 --------- Co-authored-by: Nick Schuch <nick@myschuch.com>
* Bump to Go 1.24 * Remove Alpine 3.19
kimpepper
force-pushed
the
sync-upstream
branch
from
e7871c7 to
fdec8d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR syncs with the upstream sajari/docconv repo.
I also builds on top of #10