Open
Conversation
…bly missing comma or }
- Renamed variables as requested by linter - Used slices.Contains better - Did error-checking on rows.ColumnTypes
…number of imports
internal/mysql/utils_test.go: - Passed in second parameter for all tests - Added a new test so that we can test both numbers in a numeric type and numbers in a non-numeric type internal/mysql/write.go: - Converted type to uppercase before passing to getValue internal/mysql/write_test.go: - Switched around parameters to assert.Equal, because they were in the wrong order - Added quotes to the insert statements, because apparently that's what they do now (unless we can figure out a way to have sql_mock do column.DatabaseTypeName())
Contributor
Author
Contributor
Author
|
Tagging @nickschuch just in case he doesn't get notifications for PRs (apologies if you already do). |
Collaborator
|
Somehow I missed this! Sorry @tnelson-doghouse ! Ill review it this week and go from there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the issue writeup at https://github.com/skpr/mtk/issues/36 , the sanitiser was outputting unquoted numbers in the dump if the text was only a number, even if the field type wasn't a numeric type.
This PR adds an additional check against the known Numeric types in MySQL. If it's a known numeric type, it keeps the current behaviour, but if it's not (ie. if it's a TEXT, VARCHAR, or JSON type), it will still quote the number.
This should result in fewer errors when trying to import a sanitised dump.