test: add regression coverage for server startup imports#357
Open
aneek22112007-tech wants to merge 1 commit into
Open
test: add regression coverage for server startup imports#357aneek22112007-tech wants to merge 1 commit into
aneek22112007-tech wants to merge 1 commit into
Conversation
This also includes the fix for the fit_predict_tool import error in server.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A recent issue caused the MCP server to fail at startup due to a broken tool import (
cannot import name 'fit_predict_tool' from sktime_mcp.tools.data_tools). This happens when tools are refactored, renamed, or moved, but the mainserver.pyfile is not updated to reflect those changes.Solution
This PR does two things:
fit_predict_toolimport inserver.py.tests/test_server_startup.pyto act as a fast, isolated regression guard.test_server_import_success: verifiesimport sktime_mcp.serversucceeds without anyImportError.test_server_tools_registration: validates that the underlying MCP server object properly initializes and has critical expected tools registered (e.g.,fit_predict,load_data_source).Testing