test: add horizon validation tests for fit_predict_tool and fit_predict_async_tool#368
Open
rupeshca007 wants to merge 1 commit into
Open
test: add horizon validation tests for fit_predict_tool and fit_predict_async_tool#368rupeshca007 wants to merge 1 commit into
rupeshca007 wants to merge 1 commit into
Conversation
rupeshca007
changed the title
rupeshca007
force-pushed
the
fix/horizon-validation
branch
from
April 29, 2026 09:19
c93406f to
4d4e24f
Compare
…ct_async_tool (closes sktime#367)
rupeshca007
force-pushed
the
fix/horizon-validation
branch
from
April 29, 2026 09:28
4d4e24f to
bde5927
Compare
rupeshca007
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #367
What this adds
test_param_validation.pycurrently only tests horizon validation forpredict_tool. This PR adds the missing parametrized test classes forfit_predict_toolandfit_predict_async_tool, ensuring the_validate_horizonguard is explicitly covered for all three functions.Changes
tests/test_param_validation.py:TestFitPredictToolHorizonValidationwith 6 parametrized casesTestFitPredictAsyncToolHorizonValidationwith 6 parametrized casesfit_predict_toolandfit_predict_async_toolEach test class covers:
horizon=0-> rejected ("greater than 0")horizon=-1-> rejected ("greater than 0")horizon=-100-> rejected ("greater than 0")horizon="twelve"-> rejected ("must be an integer")horizon=3.5-> rejected ("must be an integer")horizon=None-> rejected ("must be an integer")Test Results
34 passed, 0 failed