Feat: add lsSKY -> SKY farm deployment script - #37
Merged
Conversation
amusingaxl
force-pushed
the
feat/sky-farms-deployment
branch
from
October 7, 2025 17:50
5a15c5e to
7a284d1
Compare
| StakingRewardsInit.init(p.rewards, StakingRewardsInitParams({dist: p.dist})); | ||
|
|
||
| // Increase `rewardsToken` `p.vest` allowance from the treasury for `p.vestTot`. | ||
| // Note: `p.vest` is expected to be of type `DssVestTransferrable` |
There was a problem hiding this comment.
To enforce those expectations and for the sake of sanity, you can check DssVestTransferrable.czar value (as this interface is only present on transferrable vests)
oddaf
reviewed
Oct 10, 2025
oddaf
previously approved these changes
Oct 10, 2025
amusingaxl
requested review from
riccardopersiani
and removed request for
0xdecr1pto and
SidestreamColdMelon
October 14, 2025 15:21
amusingaxl
commented
Oct 14, 2025
| _checkFarm_init_afterSpell(fp, v); | ||
| } | ||
|
|
||
| function testFarm_integration_stakeGetRewardAndwithdraw() internal { |
Member
There was a problem hiding this comment.
Suggested change
| function testFarm_integration_stakeGetRewardAndwithdraw() internal { | |
| function testFarm_integration_stakeGetRewardAndWithdraw() public { |
as you pointed out.
riccardopersiani
previously approved these changes
Oct 14, 2025
riccardopersiani
self-requested a review
October 14, 2025 20:58
riccardopersiani
approved these changes
Oct 14, 2025
oddaf
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.