SK-2770: publish v1.x releases under the v1 dist-tag to preserve latest as V2#297
Merged
Devesh-Skyflow merged 2 commits intomainfrom Apr 23, 2026
Merged
Conversation
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
skyflow-bharti
approved these changes
Apr 23, 2026
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Publishing a v1.x patch release via the public release workflow ran
npm publishwithout an explicit dist-tag. npm defaults tolatest,so every v1 patch silently overwrote the
latestpointer away from v2.Solution
In
common-release.yml, read the major version frompackage.json(already bumped by
bump_version.shbefore this step) and branch:1→npm publish --tag v12→npm publish(keepslateston v2)User impact
npm install skyflow-nodenpm install skyflow-node@v1npm install skyflow-node@betaNo changes to trigger workflows or version-bumping logic.