Repository navigation
radar-hub README: the release job promotes staged charts (1.10.1-rc.1) - #58
Open
nadaverell wants to merge 1 commit into
Open
nadaverell wants to merge 1 commit into
nadaverell wants to merge 1 commit into
Conversation
PR Summary by QodoClarify Radar Hub chart promotion and sandbox image versioning
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can route each severity your way: inline, summary, both, or drop |
3 tasks done
The README said to promote a staged prerelease chart by hand. The Hub release job has done that since next-chart-version.sh learned prereleases: a Hub tag turns 1.7.0-rc.1 into 1.7.0 and sets appVersion in the same commit. It also listed only the hub and web images under appVersion and pinning; the AI agent sandbox image defaults to appVersion too. Docs only. Staged as 1.10.1-rc.1 because ct lint requires a version bump for any change under the chart; the next Hub release promotes it.
nadaverell
force-pushed
the
radar-hub-readme-release-notes
branch
from
October 7, 2026 19:02
77d3a36 to
9d0873b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs-only fixes to
charts/radar-hub, found during the 1.10.0 release.versionandappVersionby hand when the Hub release lands. The Hub release job already does this: a HubvX.Y.Ztag turns a stagedA.B.0-rc.NintoA.B.0and setsappVersionin the same commit (scripts/next-chart-version.shin radar-hub). It did so for 1.10.0. The README now says so and warns against promoting by hand.appVersionrow, the pinning paragraph and theChart.yamlcomment listed only the hub and web images.image.agentSandbox.tagdefaults toappVersiontoo (_helpers.tpl), and the sandbox is version-locked to the hub.Version:
1.10.1-rc.1.ct lintneeds a version bump for any change in the chart directory. A prerelease keeps a docs change from showing up as a new chart for customers; the next Hub release promotes it.appVersionis unchanged. #51 rebases onto this and takes the next minor.Test plan
ct lint --target-branch mainhelm unittest charts/radar-hub: 20/20next-chart-version.shagainst the current tags returns1.10.1for the next Hub releaseNote
Low Risk
Documentation and chart metadata only; no template or runtime behavior changes.
Overview
Docs-only update to
charts/radar-hubversioning guidance, with chartversionbumped to1.10.1-rc.1(appVersionstill 1.10.0) soct lintcan publish a prerelease instead of a new stable chart for customers.The README now documents that
image.agentSandbox.tagdefaults toappVersionalongside hub and web, and that all three should be pinned to the same tag. It also corrects staged chart promotion: the Hub release job (onvX.Y.Z) promotes*-rc.Nto stable and setsappVersionin one commit—manual promotion is discouraged.Chart.yamlcomments match the three-image pinning story.Reviewed by Cursor Bugbot for commit 9d0873b. Bugbot is set up for automated code reviews on this repo. Configure here.