Skip to content

radar-hub README: the release job promotes staged charts (1.10.1-rc.1) - #58

Open
nadaverell wants to merge 1 commit into
mainfrom
radar-hub-readme-release-notes
Open

nadaverell wants to merge 1 commit into
mainfrom
radar-hub-readme-release-notes

Conversation

@nadaverell

@nadaverell nadaverell commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Docs-only fixes to charts/radar-hub, found during the 1.10.0 release.

  • Promoting a staged chart: the README said to bump version and appVersion by hand when the Hub release lands. The Hub release job already does this: a Hub vX.Y.Z tag turns a staged A.B.0-rc.N into A.B.0 and sets appVersion in the same commit (scripts/next-chart-version.sh in radar-hub). It did so for 1.10.0. The README now says so and warns against promoting by hand.
  • Sandbox image: the appVersion row, the pinning paragraph and the Chart.yaml comment listed only the hub and web images. image.agentSandbox.tag defaults to appVersion too (_helpers.tpl), and the sandbox is version-locked to the hub.

Version: 1.10.1-rc.1. ct lint needs a version bump for any change in the chart directory. A prerelease keeps a docs change from showing up as a new chart for customers; the next Hub release promotes it. appVersion is unchanged. #51 rebases onto this and takes the next minor.

Test plan

  • ct lint --target-branch main
  • helm unittest charts/radar-hub: 20/20
  • next-chart-version.sh against the current tags returns 1.10.1 for the next Hub release

Note

Low Risk
Documentation and chart metadata only; no template or runtime behavior changes.

Overview
Docs-only update to charts/radar-hub versioning guidance, with chart version bumped to 1.10.1-rc.1 (appVersion still 1.10.0) so ct lint can publish a prerelease instead of a new stable chart for customers.

The README now documents that image.agentSandbox.tag defaults to appVersion alongside hub and web, and that all three should be pinned to the same tag. It also corrects staged chart promotion: the Hub release job (on vX.Y.Z) promotes *-rc.N to stable and sets appVersion in one commit—manual promotion is discouraged. Chart.yaml comments match the three-image pinning story.

Reviewed by Cursor Bugbot for commit 9d0873b. Bugbot is set up for automated code reviews on this repo. Configure here.

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Clarify Radar Hub chart promotion and sandbox image versioning

📝 Documentation ⚙️ Configuration changes 🕐 Less than 10 minutes

Grey Divider

AI Description

• Clarify that the Hub release job promotes staged charts and updates appVersion; maintainers
 should not promote them manually.
• Document that the sandbox image, like Hub and Web, defaults to appVersion and should be pinned
 alongside them.
• Stage the documentation change as chart version 1.10.1-rc.1, leaving appVersion unchanged.
Diagram

graph TD
  T["Hub release tag"] --> J("Hub release job") --> C["Chart metadata"] --> D["Image tag defaults"] --> H["Hub image"]
  S["Staged prerelease"] --> J
  D --> W["Web image"]
  D --> A["Sandbox image"]
Loading
High-Level Assessment

Documenting the existing release automation is preferable to manual promotion, which risks advancing the chart without its default image versions. A prerelease chart version satisfies the chart lint requirement without presenting this documentation change as a new stable chart.

Files changed (2) +19 / -17

Documentation (1) +12 / -10
README.mdCorrect release-promotion and image-pinning guidance +12/-10

Correct release-promotion and image-pinning guidance

• Explains that the Hub release job promotes a staged chart and updates 'appVersion' in the same commit, rather than requiring manual promotion. Adds the sandbox image to the versioning and pinning guidance.

charts/radar-hub/README.md

Other (1) +7 / -7
Chart.yamlStage chart version and clarify sandbox image default +7/-7

Stage chart version and clarify sandbox image default

• Bumps the chart version from '1.10.0' to '1.10.1-rc.1' while leaving 'appVersion' at '1.10.0'. Expands the metadata comment to include the sandbox image's 'appVersion' default.

charts/radar-hub/Chart.yaml

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can route each severity your way: inline, summary, both, or drop

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

The README said to promote a staged prerelease chart by hand. The Hub release
job has done that since next-chart-version.sh learned prereleases: a Hub tag
turns 1.7.0-rc.1 into 1.7.0 and sets appVersion in the same commit. It also
listed only the hub and web images under appVersion and pinning; the AI agent
sandbox image defaults to appVersion too.

Docs only. Staged as 1.10.1-rc.1 because ct lint requires a version bump for
any change under the chart; the next Hub release promotes it.
@nadaverell
nadaverell force-pushed the radar-hub-readme-release-notes branch from 77d3a36 to 9d0873b Compare October 7, 2026 19:02

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant